You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by mi...@apache.org on 2019/01/02 14:34:49 UTC
[incubator-dubbo-ops] branch develop updated: Optimize logging
(#226)
This is an automated email from the ASF dual-hosted git repository.
min pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-ops.git
The following commit(s) were added to refs/heads/develop by this push:
new 956b60e Optimize logging (#226)
956b60e is described below
commit 956b60ec7507497f37813a15e4e3a80702e4c207
Author: Yuhao Bi <by...@gmail.com>
AuthorDate: Wed Jan 2 22:34:44 2019 +0800
Optimize logging (#226)
using logging framework instead of printStack to console
---
.../java/org/apache/dubbo/admin/common/util/MD5Util.java | 6 +++++-
.../dubbo/admin/data/config/impl/ZookeeperConfiguration.java | 12 +++++++-----
.../admin/data/metadata/impl/ZookeeperMetaDataCollector.java | 5 ++++-
3 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/common/util/MD5Util.java b/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/common/util/MD5Util.java
index a44a849..ad01650 100644
--- a/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/common/util/MD5Util.java
+++ b/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/common/util/MD5Util.java
@@ -17,11 +17,15 @@
package org.apache.dubbo.admin.common.util;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
public class MD5Util {
+ private static final Logger logger = LoggerFactory.getLogger(MD5Util.class);
private static MessageDigest md;
private static final char[] hexCode = "0123456789ABCDEF".toCharArray();
@@ -29,7 +33,7 @@ public class MD5Util {
try {
md = MessageDigest.getInstance("MD5");
} catch (NoSuchAlgorithmException e) {
- e.printStackTrace();
+ logger.error(e.getMessage(), e);
}
}
diff --git a/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/data/config/impl/ZookeeperConfiguration.java b/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/data/config/impl/ZookeeperConfiguration.java
index 95e7988..c0540d5 100644
--- a/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/data/config/impl/ZookeeperConfiguration.java
+++ b/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/data/config/impl/ZookeeperConfiguration.java
@@ -22,18 +22,20 @@ import org.apache.curator.framework.CuratorFrameworkFactory;
import org.apache.curator.retry.ExponentialBackoffRetry;
import org.apache.dubbo.admin.common.util.Constants;
import org.apache.dubbo.admin.data.config.GovernanceConfiguration;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
import org.apache.dubbo.common.URL;
-import javax.swing.*;
public class ZookeeperConfiguration implements GovernanceConfiguration {
+ private static final Logger logger = LoggerFactory.getLogger(ZookeeperConfiguration.class);
private CuratorFramework zkClient;
private URL url;
private String root;
@Override
public void setUrl(URL url) {
- this.url = url;
+ this.url = url;
}
@Override
@@ -77,7 +79,7 @@ public class ZookeeperConfiguration implements GovernanceConfiguration {
zkClient.setData().forPath(path, value.getBytes());
return value;
} catch (Exception e) {
-
+ logger.error(e.getMessage(), e);
}
return null;
}
@@ -92,7 +94,7 @@ public class ZookeeperConfiguration implements GovernanceConfiguration {
}
return new String(zkClient.getData().forPath(path));
} catch (Exception e) {
- e.printStackTrace();
+ logger.error(e.getMessage(), e);
}
return null;
}
@@ -103,7 +105,7 @@ public class ZookeeperConfiguration implements GovernanceConfiguration {
try {
zkClient.delete().forPath(path);
} catch (Exception e) {
- e.printStackTrace();
+ logger.error(e.getMessage(), e);
}
return true;
}
diff --git a/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/data/metadata/impl/ZookeeperMetaDataCollector.java b/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/data/metadata/impl/ZookeeperMetaDataCollector.java
index 0ecab02..fcab3b0 100644
--- a/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/data/metadata/impl/ZookeeperMetaDataCollector.java
+++ b/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/data/metadata/impl/ZookeeperMetaDataCollector.java
@@ -23,10 +23,13 @@ import org.apache.curator.retry.ExponentialBackoffRetry;
import org.apache.dubbo.admin.common.util.Constants;
import org.apache.dubbo.admin.data.metadata.MetaDataCollector;
import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
import org.apache.dubbo.metadata.identifier.MetadataIdentifier;
public class ZookeeperMetaDataCollector implements MetaDataCollector {
+ private static final Logger logger = LoggerFactory.getLogger(ZookeeperMetaDataCollector.class);
private CuratorFramework client;
private URL url;
private String root;
@@ -86,7 +89,7 @@ public class ZookeeperMetaDataCollector implements MetaDataCollector {
}
return new String(client.getData().forPath(path));
} catch (Exception e) {
- e.printStackTrace();
+ logger.error(e.getMessage(), e);
}
return null;
}