You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/28 16:05:05 UTC
[GitHub] [cloudstack-documentation] Hudratronium opened a new pull request #192: Dev
Hudratronium opened a new pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192
Hi,
made some minor changes regarding wording. Also added some notes as this part of documentations aims for an productive environment.
With regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] rhtyd commented on pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192#issuecomment-846947792
@Hudratronium that's no true, you need to mask the services to get old behaviour. We've fixed that in cloudstack-agent I think, @shwstppr @davidjumani - can you confirm?
On Ubuntu we've to do this to then get libvirtd listen on tcp/ssl port:
```
systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket
systemctl restart libvirtd
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] GabrielBrascher commented on a change in pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192#discussion_r585286376
##########
File path: source/installguide/management-server/_nfs.rst
##########
@@ -237,12 +237,34 @@ operating system version.
#. Log back in to the hypervisor host and try to mount the /export
directories. For example, substitute your own management server
name:
-
- .. parsed-literal::
-
- mkdir /primary
- mount -t nfs <management-server-name>:/export/primary
- umount /primary
- mkdir /secondary
- mount -t nfs <management-server-name>:/export/secondary
- umount /secondary
+
+ #. Creat directories for testing.
Review comment:
`Creat` -> `Create`
##########
File path: source/installguide/management-server/_database.rst
##########
@@ -22,8 +22,9 @@ node, you can install the MySQL server locally. For an installation that
has multiple management server nodes, we assume the MySQL database also
runs on a separate node.
-CloudStack has been tested with MySQL 5.1 and 5.5. These versions are
-included in RHEL/CentOS and Ubuntu.
+CloudStack has been tested with MySQL 5.1 ,5.5 and 8.0. The versions 5.1
+and 5.5 are included in RHEL/CentOS and Ubuntu.
+For MySQL 8.0 please refer to the offical / community repositories of the product..
Review comment:
Remove duplicated `..` at the end.
##########
File path: source/installguide/management-server/_database.rst
##########
@@ -22,8 +22,9 @@ node, you can install the MySQL server locally. For an installation that
has multiple management server nodes, we assume the MySQL database also
runs on a separate node.
-CloudStack has been tested with MySQL 5.1 and 5.5. These versions are
-included in RHEL/CentOS and Ubuntu.
+CloudStack has been tested with MySQL 5.1 ,5.5 and 8.0. The versions 5.1
Review comment:
Minnor formatation of the comma: `MySQL 5.1 ,5.5 and 8.0.` -> `MySQL 5.1, 5.5 and 8.0.`
##########
File path: source/installguide/hypervisor/kvm.rst
##########
@@ -289,15 +289,7 @@ cloudstack-agent and should already be installed.
#. Turning on "listen\_tcp" in libvirtd.conf is not enough, we have to
change the parameters as well:
- On RHEL or CentOS modify ``/etc/sysconfig/libvirtd``:
-
- Uncomment the following line:
-
- .. parsed-literal::
-
- #LIBVIRTD_ARGS="--listen"
-
- On Ubuntu 14.04: modify ``/etc/default/libvirt-bin``
+ On Ubuntu 14.04: modify ``/etc/default/libvirt-bin``
Review comment:
It would also be good to remove Ubuntu 14.04 from documentation as it is no longer supported.
##########
File path: source/installguide/management-server/_database.rst
##########
@@ -293,6 +294,9 @@ same node for MySQL. See `“Install the Database on the Management Server Node
sudo service mysql restart
+ .. note::
+ Before performing a reboot of the management server please check if mysql is configured to start automatically.
Review comment:
`mysql` -> `MySQL`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192#issuecomment-791502715
requesting docbuild
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] Hudratronium commented on pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0
Posted by GitBox <gi...@apache.org>.
Hudratronium commented on pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192#issuecomment-848034044
@rhtyd
okay, will do so :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] Hudratronium closed pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0
Posted by GitBox <gi...@apache.org>.
Hudratronium closed pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0
Posted by GitBox <gi...@apache.org>.
ACSGitBot commented on pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192#issuecomment-791504151
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr192//
Build Log Output:
No log errors found to report.//
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0
Posted by GitBox <gi...@apache.org>.
ACSGitBot commented on pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192#issuecomment-791502766
Your request had been received, i'll go and build the documentation and check the output log for errors.
This shouldn't take long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] Hudratronium commented on pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0
Posted by GitBox <gi...@apache.org>.
Hudratronium commented on pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192#issuecomment-847138265
>
>
> @Hudratronium that's no true, you need to mask the services to get old behaviour. We've fixed that in cloudstack-agent I think, @shwstppr @davidjumani - can you confirm?
>
> On Ubuntu we've to do this to then get libvirtd listen on tcp/ssl port:
>
> ```
> systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket
> systemctl restart libvirtd
> ```
Hi @rhtyd
At that time i raised an issue that, as far as i got this, is fixed for release 4.15.1
https://github.com/apache/cloudstack/issues/4754
On Ubuntu - as fas as i understood @shwstppr , that was already part of the configuration script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] rhtyd commented on pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192#issuecomment-847868732
@Hudratronium yes that's correct. This is fixed for 4.15.1 in https://github.com/apache/cloudstack/pull/4756 and therefore I think the doc changes are not necessary, this PR can be closed. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] Hudratronium edited a comment on pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0
Posted by GitBox <gi...@apache.org>.
Hudratronium edited a comment on pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192#issuecomment-847138265
>
>
> @Hudratronium that's no true, you need to mask the services to get old behaviour. We've fixed that in cloudstack-agent I think, @shwstppr @davidjumani - can you confirm?
>
> On Ubuntu we've to do this to then get libvirtd listen on tcp/ssl port:
>
> ```
> systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket
> systemctl restart libvirtd
> ```
Hi @rhtyd
At that time i raised an issue that, as far as i got this, is fixed for release 4.15.1
https://github.com/apache/cloudstack/issues/4754
On Ubuntu - as fas as i understood @shwstppr , that was already part of the configuration script.
It might be an idea, as this topic is quiet crucial, that for the offical guides some of the developers add some content to the documentation.
From an user point of view, the kvm-installation in the docs inherits an manual configuration of libvirt (as well as SELinux / AppArmor).
As far as i got during the last months, this is all done automatically during the cloudstack-agent installation.
So it might be good to restructure the whole side and give some additonal input which configurtation is done already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org