[GitHub] [incubator-pegasus] acelyc111 commented on a change in pull request #639: feat(hotkey): add unit test of internal_collector

[GitBox <gi...@apache.org>]

acelyc111 commented on a change in pull request #639:
URL: https://github.com/apache/incubator-pegasus/pull/639#discussion_r521039718



##########
File path: src/server/hotkey_collector.h
##########
@@ -30,9 +33,13 @@ class internal_collector_base;
 struct detect_hotkey_result
 {
     int coarse_bucket_index = -1;
-    std::string hot_hash_key;
+    std::string hot_hash_key = "";

Review comment:
       Not needed to assign an empty string, default constructor already behave like this.

##########
File path: src/server/hotkey_collector.h
##########
@@ -89,13 +96,18 @@ class hotkey_collector : public dsn::replication::replica_base
     void terminate();
     bool terminate_if_timeout();
 
+    static int get_bucket_id(dsn::string_view data);
+    static bool
+    find_outlier_index(const std::vector<uint64_t> &captured_keys, int threshold, int &hot_index);

Review comment:
       Have you implement these functions?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org