You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/27 23:28:37 UTC

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6933: [AIRFLOW-6376] Extract order_queued_tasks_by_priority method

nuclearpinguin commented on a change in pull request #6933: [AIRFLOW-6376] Extract order_queued_tasks_by_priority method
URL: https://github.com/apache/airflow/pull/6933#discussion_r361761418
 
 

 ##########
 File path: airflow/executors/base_executor.py
 ##########
 @@ -150,16 +150,25 @@ def heartbeat(self) -> None:
         self.log.debug("Calling the %s sync method", self.__class__)
         self.sync()
 
-    def trigger_tasks(self, open_slots: int) -> None:
+    def order_queued_tasks_by_priority(self) -> List[Tuple[TaskInstanceKeyType, QueuedTaskInstanceType]]:
 
 Review comment:
   What do you think about making this a property?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services