You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/03/25 17:40:43 UTC

[Impala-ASF-CR] Revert "IMPALA-11116: Make DESCRIBE HISTORY parameterized"

Hello Zoltan Borok-Nagy, Impala Public Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/18354

to review the following change.


Change subject: Revert "IMPALA-11116: Make DESCRIBE HISTORY parameterized"
......................................................................

Revert "IMPALA-11116: Make DESCRIBE HISTORY parameterized"

The import list of the Frontend class has been cleaned as part of this change, however between the merge and verified job another commit started to use the ExecutorMembershipSnapshot class. Reverting this commit to fix the builds.

This reverts commit 72f074539c4bb2fe663d748f97cd62df88337f27.

Change-Id: I5d175196862fe05836bbc9b215dc573c7d33d021
---
M common/thrift/Frontend.thrift
M docs/topics/impala_iceberg.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M tests/query_test/test_iceberg.py
8 files changed, 24 insertions(+), 286 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/18354/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d175196862fe05836bbc9b215dc573c7d33d021
Gerrit-Change-Number: 18354
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] Revert "IMPALA-11116: Make DESCRIBE HISTORY parameterized"

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has abandoned this change. ( http://gerrit.cloudera.org:8080/18354 )

Change subject: Revert "IMPALA-11116: Make DESCRIBE HISTORY parameterized"
......................................................................


Abandoned

Abandoning this path, fixing the build import as it requires a CR anyway.
-- 
To view, visit http://gerrit.cloudera.org:8080/18354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5d175196862fe05836bbc9b215dc573c7d33d021
Gerrit-Change-Number: 18354
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] Revert "IMPALA-11116: Make DESCRIBE HISTORY parameterized"

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has created a revert of this change. ( http://gerrit.cloudera.org:8080/18354 )

Change subject: Revert "IMPALA-11116: Make DESCRIBE HISTORY parameterized"
......................................................................


Uploaded patch set 1.
-- 
To view, visit http://gerrit.cloudera.org:8080/18354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: revert
Gerrit-Change-Id: I5d175196862fe05836bbc9b215dc573c7d33d021
Gerrit-Change-Number: 18354
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] Revert "IMPALA-11116: Make DESCRIBE HISTORY parameterized"

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18354

to look at the new patch set (#2).

Change subject: Revert "IMPALA-11116: Make DESCRIBE HISTORY parameterized"
......................................................................

Revert "IMPALA-11116: Make DESCRIBE HISTORY parameterized"

The import list of the Frontend class has been cleaned as part of this
change, however between the merge and verified job another commit
started to use the ExecutorMembershipSnapshot class. Reverting this
commit to fix the builds.

This reverts commit 72f074539c4bb2fe663d748f97cd62df88337f27.

Change-Id: I5d175196862fe05836bbc9b215dc573c7d33d021
---
M common/thrift/Frontend.thrift
M docs/topics/impala_iceberg.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/DescribeHistoryStmt.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M tests/query_test/test_iceberg.py
8 files changed, 24 insertions(+), 286 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/18354/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d175196862fe05836bbc9b215dc573c7d33d021
Gerrit-Change-Number: 18354
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>