You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by hu...@apache.org on 2018/08/13 21:33:50 UTC

[incubator-heron] 02/02: use list

This is an automated email from the ASF dual-hosted git repository.

huijun pushed a commit to branch huijunw/refactorhealthmgr0.2.3
in repository https://gitbox.apache.org/repos/asf/incubator-heron.git

commit 062538549a59d61ac9ef7d43f9dfa3882084b133
Author: Huijun Wu <hu...@twitter.com>
AuthorDate: Mon Aug 13 14:33:17 2018 -0700

    use list
---
 heron/executor/src/python/heron_executor.py                            | 3 +--
 .../java/org/apache/heron/healthmgr/sensors/BackPressureSensor.java    | 2 +-
 .../src/java/org/apache/heron/healthmgr/sensors/BufferSizeSensor.java  | 2 +-
 .../java/org/apache/heron/healthmgr/sensors/ExecuteCountSensor.java    | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/heron/executor/src/python/heron_executor.py b/heron/executor/src/python/heron_executor.py
index c53a608..d62b7da 100755
--- a/heron/executor/src/python/heron_executor.py
+++ b/heron/executor/src/python/heron_executor.py
@@ -506,8 +506,7 @@ class HeronExecutor(object):
                      "--role", self.role,
                      "--environment", self.environment,
                      "--topology_name", self.topology_name,
-                     "--metricsmgr_port", self.metrics_manager_port,
-                     "--verbose"]
+                     "--metricsmgr_port", self.metrics_manager_port]
 
     return healthmgr_cmd
 
diff --git a/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/BackPressureSensor.java b/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/BackPressureSensor.java
index 0d94653..857b17b 100644
--- a/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/BackPressureSensor.java
+++ b/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/BackPressureSensor.java
@@ -70,7 +70,7 @@ public class BackPressureSensor extends BaseSensor {
     Collection<Measurement> result = new ArrayList<>();
     Instant now = context.checkpoint();
 
-    Collection<String> boltComponents = physicalPlanProvider.getBoltNames();
+    List<String> boltComponents = physicalPlanProvider.getBoltNames();
     Duration duration = getDuration();
     for (String component : boltComponents) {
       String[] boltInstanceNames = packingPlanProvider.getBoltInstanceNames(component);
diff --git a/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/BufferSizeSensor.java b/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/BufferSizeSensor.java
index b407cce..9ed271a 100644
--- a/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/BufferSizeSensor.java
+++ b/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/BufferSizeSensor.java
@@ -62,7 +62,7 @@ public class BufferSizeSensor extends BaseSensor {
     Collection<Measurement> result = new ArrayList<>();
     Instant now = context.checkpoint();
 
-    Collection<String> boltComponents = physicalPlanProvider.getBoltNames();
+    List<String> boltComponents = physicalPlanProvider.getBoltNames();
     Duration duration = getDuration();
 
     for (String component : boltComponents) {
diff --git a/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/ExecuteCountSensor.java b/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/ExecuteCountSensor.java
index 94fd48a..d38df4c 100644
--- a/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/ExecuteCountSensor.java
+++ b/heron/healthmgr/src/java/org/apache/heron/healthmgr/sensors/ExecuteCountSensor.java
@@ -50,7 +50,7 @@ public class ExecuteCountSensor extends BaseSensor {
 
   @Override
   public Collection<Measurement> fetch() {
-    Collection<String> bolts = physicalPlanProvider.getBoltNames();
+    List<String> bolts = physicalPlanProvider.getBoltNames();
     now = context.checkpoint();
     return metricsProvider.getMeasurements(now, getDuration(), getMetricTypes(), bolts);
   }