You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Matthias J. Sax (Jira)" <ji...@apache.org> on 2021/12/21 19:35:00 UTC
[jira] [Commented] (KAFKA-13561) Consider deprecating `StreamsBuilder#build(props)` function
[ https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463436#comment-17463436 ]
Matthias J. Sax commented on KAFKA-13561:
-----------------------------------------
My personal idea was actually to deprecate `StreamsBilder#build()`? Don't think it would be better to pass in `StreamsConfig` via the constructor instead of `build(props)`?
> Consider deprecating `StreamsBuilder#build(props)` function
> -----------------------------------------------------------
>
> Key: KAFKA-13561
> URL: https://issues.apache.org/jira/browse/KAFKA-13561
> Project: Kafka
> Issue Type: Improvement
> Reporter: Guozhang Wang
> Priority: Major
>
> With https://cwiki.apache.org/confluence/display/KAFKA/KIP-591%3A+Add+Kafka+Streams+config+to+set+default+state+store being accepted that introduced the new `StreamsBuilder(TopologyConfig)` constructor, we can consider deprecating the `StreamsBuilder#build(props)` function now. There are still a few things we'd need to do:
> 1. Copy the `StreamsConfig.TOPOLOGY_OPTIMIZATION_CONFIG` to TopologyConfig.
> 2. Make sure the overloaded `StreamsBuilder()` constructor takes in default values of TopologyConfig.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)