You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/09/14 00:20:13 UTC
[GitHub] [iceberg] kbendick opened a new pull request #1452: Add a null precondition check to the varargs BaseCombinedTask constructor
kbendick opened a new pull request #1452:
URL: https://github.com/apache/iceberg/pull/1452
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue removed a comment on pull request #1452: Add a null precondition check to the varargs BaseCombinedTask constructor
Posted by GitBox <gi...@apache.org>.
rdblue removed a comment on pull request #1452:
URL: https://github.com/apache/iceberg/pull/1452#issuecomment-692853891
Looks good to me. We could remove this, but I don't mind either way. It is safer for compatibility to keep it and it's not causing an unreasonable amount of maintenance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1452: Add a null precondition check to the varargs BaseCombinedTask constructor
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1452:
URL: https://github.com/apache/iceberg/pull/1452#issuecomment-691768273
I should note that currently the varargs constructor is unused according to my IDE, so we might also have the option of simply removing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1452: Add a null precondition check to the varargs BaseCombinedTask constructor
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1452:
URL: https://github.com/apache/iceberg/pull/1452
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1452: Add a null precondition check to the varargs BaseCombinedTask constructor
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1452:
URL: https://github.com/apache/iceberg/pull/1452#issuecomment-692853891
Looks good to me. We could remove this, but I don't mind either way. It is safer for compatibility to keep it and it's not causing an unreasonable amount of maintenance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1452: Add a null precondition check to the varargs BaseCombinedTask constructor
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1452:
URL: https://github.com/apache/iceberg/pull/1452#issuecomment-692855087
After thinking about this a little more, I think we should remove the other constructor. The problem with it is that it doesn't copy the incoming array, so the contents of the split could be modified afterwards. We could add `Arrays.copyOf` to fix it, but since this constructor is unused, we should just remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org