You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/01/17 13:28:29 UTC
Review Request 55617: AMBARI-19585. Client config tags may not be
saved by agent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55617/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19585
https://issues.apache.org/jira/browse/AMBARI-19585
Repository: ambari
Description
-------
Fetch service/component map before executing first command, too, do not wait until first status command.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Controller.py d00ffae50e01821edf8ec2c9ac2f4c9ca0e4986d
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py d4f543617b1f511e68a371b346760f330c40f04e
ambari-agent/src/test/python/ambari_agent/TestController.py b47af0369a471c37e82e802e6e1d953031cac82d
Diff: https://reviews.apache.org/r/55617/diff/
Testing
-------
Manual testing:
* create cluster via blueprint
* verify `*_config.json` is created for client components whose installation finished before the first status command (FALCON_CLIENT and HBASE_CLIENT below)
```
$ grep 'Adding.*command\|Executing command.*CLIENT' /var/log/ambari-agent/ambari-agent.log
INFO 2017-01-17 13:00:42,495 Controller.py:248 - Adding 39 commands. Heartbeat id = 15
INFO 2017-01-17 13:00:53,138 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 5 for role = FALCON_CLIENT of cluster TEST.
INFO 2017-01-17 13:00:55,174 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 7 for role = HBASE_CLIENT of cluster TEST.
INFO 2017-01-17 13:01:32,992 Controller.py:257 - Adding 8 status commands. Heartbeat id = 69
INFO 2017-01-17 13:01:51,245 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 11 for role = HDFS_CLIENT of cluster TEST.
INFO 2017-01-17 13:01:53,232 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 13 for role = HIVE_CLIENT of cluster TEST.
...
$ ls -l --full-time /var/lib/ambari-agent/data/*_CLIENT_config*
-rw-r--r-- 1 root root 6327 2017-01-17 13:00:54.167877626 +0000 /var/lib/ambari-agent/data/FALCON_CLIENT_config.json
-rw-r--r-- 1 root root 6327 2017-01-17 13:00:56.496747403 +0000 /var/lib/ambari-agent/data/HBASE_CLIENT_config.json
-rw-r--r-- 1 root root 6327 2017-01-17 13:01:52.317955884 +0000 /var/lib/ambari-agent/data/HDFS_CLIENT_config.json
-rw-r--r-- 1 root root 6327 2017-01-17 13:01:54.465860199 +0000 /var/lib/ambari-agent/data/HIVE_CLIENT_config.json
```
Unit tests:
```
$ mvn -pl ambari-agent -DskipSurefireTests test
...
Ran 453 tests in 13.271s
OK
...
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 156 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
```
Thanks,
Attila Doroszlai
Re: Review Request 55617: AMBARI-19585. Client config tags may not be
saved by agent
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55617/#review162057
-----------------------------------------------------------
Ship it!
Ship It!
- Sandor Magyari
On Jan. 17, 2017, 1:28 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55617/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 1:28 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19585
> https://issues.apache.org/jira/browse/AMBARI-19585
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fetch service/component map before executing first command, too, do not wait until first status command.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Controller.py d00ffae50e01821edf8ec2c9ac2f4c9ca0e4986d
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py d4f543617b1f511e68a371b346760f330c40f04e
> ambari-agent/src/test/python/ambari_agent/TestController.py b47af0369a471c37e82e802e6e1d953031cac82d
>
> Diff: https://reviews.apache.org/r/55617/diff/
>
>
> Testing
> -------
>
> Manual testing:
> * create cluster via blueprint
> * verify `*_config.json` is created for client components whose installation finished before the first status command (FALCON_CLIENT and HBASE_CLIENT below)
>
> ```
> $ grep 'Adding.*command\|Executing command.*CLIENT' /var/log/ambari-agent/ambari-agent.log
> INFO 2017-01-17 13:00:42,495 Controller.py:248 - Adding 39 commands. Heartbeat id = 15
> INFO 2017-01-17 13:00:53,138 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 5 for role = FALCON_CLIENT of cluster TEST.
> INFO 2017-01-17 13:00:55,174 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 7 for role = HBASE_CLIENT of cluster TEST.
> INFO 2017-01-17 13:01:32,992 Controller.py:257 - Adding 8 status commands. Heartbeat id = 69
> INFO 2017-01-17 13:01:51,245 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 11 for role = HDFS_CLIENT of cluster TEST.
> INFO 2017-01-17 13:01:53,232 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 13 for role = HIVE_CLIENT of cluster TEST.
> ...
> $ ls -l --full-time /var/lib/ambari-agent/data/*_CLIENT_config*
> -rw-r--r-- 1 root root 6327 2017-01-17 13:00:54.167877626 +0000 /var/lib/ambari-agent/data/FALCON_CLIENT_config.json
> -rw-r--r-- 1 root root 6327 2017-01-17 13:00:56.496747403 +0000 /var/lib/ambari-agent/data/HBASE_CLIENT_config.json
> -rw-r--r-- 1 root root 6327 2017-01-17 13:01:52.317955884 +0000 /var/lib/ambari-agent/data/HDFS_CLIENT_config.json
> -rw-r--r-- 1 root root 6327 2017-01-17 13:01:54.465860199 +0000 /var/lib/ambari-agent/data/HIVE_CLIENT_config.json
> ```
>
> Unit tests:
>
> ```
> $ mvn -pl ambari-agent -DskipSurefireTests test
> ...
> Ran 453 tests in 13.271s
>
> OK
> ...
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 156 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 55617: AMBARI-19585. Client config tags may not be
saved by agent
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55617/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 4:40 p.m.)
Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19585
https://issues.apache.org/jira/browse/AMBARI-19585
Repository: ambari
Description
-------
Fetch service/component map before executing first command, too, do not wait until first status command.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Controller.py d00ffae50e01821edf8ec2c9ac2f4c9ca0e4986d
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py d4f543617b1f511e68a371b346760f330c40f04e
ambari-agent/src/test/python/ambari_agent/TestController.py b47af0369a471c37e82e802e6e1d953031cac82d
Diff: https://reviews.apache.org/r/55617/diff/
Testing
-------
Manual testing:
* create cluster via blueprint
* verify `*_config.json` is created for client components whose installation finished before the first status command (FALCON_CLIENT and HBASE_CLIENT below)
```
$ grep 'Adding.*command\|Executing command.*CLIENT' /var/log/ambari-agent/ambari-agent.log
INFO 2017-01-17 13:00:42,495 Controller.py:248 - Adding 39 commands. Heartbeat id = 15
INFO 2017-01-17 13:00:53,138 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 5 for role = FALCON_CLIENT of cluster TEST.
INFO 2017-01-17 13:00:55,174 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 7 for role = HBASE_CLIENT of cluster TEST.
INFO 2017-01-17 13:01:32,992 Controller.py:257 - Adding 8 status commands. Heartbeat id = 69
INFO 2017-01-17 13:01:51,245 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 11 for role = HDFS_CLIENT of cluster TEST.
INFO 2017-01-17 13:01:53,232 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 13 for role = HIVE_CLIENT of cluster TEST.
...
$ ls -l --full-time /var/lib/ambari-agent/data/*_CLIENT_config*
-rw-r--r-- 1 root root 6327 2017-01-17 13:00:54.167877626 +0000 /var/lib/ambari-agent/data/FALCON_CLIENT_config.json
-rw-r--r-- 1 root root 6327 2017-01-17 13:00:56.496747403 +0000 /var/lib/ambari-agent/data/HBASE_CLIENT_config.json
-rw-r--r-- 1 root root 6327 2017-01-17 13:01:52.317955884 +0000 /var/lib/ambari-agent/data/HDFS_CLIENT_config.json
-rw-r--r-- 1 root root 6327 2017-01-17 13:01:54.465860199 +0000 /var/lib/ambari-agent/data/HIVE_CLIENT_config.json
```
Unit tests:
```
$ mvn -pl ambari-agent -DskipSurefireTests test
...
Ran 453 tests in 13.271s
OK
...
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 156 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
```
Thanks,
Attila Doroszlai
Re: Review Request 55617: AMBARI-19585. Client config tags may not be
saved by agent
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55617/#review161872
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Jan. 17, 2017, 2:28 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55617/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 2:28 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19585
> https://issues.apache.org/jira/browse/AMBARI-19585
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fetch service/component map before executing first command, too, do not wait until first status command.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Controller.py d00ffae50e01821edf8ec2c9ac2f4c9ca0e4986d
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py d4f543617b1f511e68a371b346760f330c40f04e
> ambari-agent/src/test/python/ambari_agent/TestController.py b47af0369a471c37e82e802e6e1d953031cac82d
>
> Diff: https://reviews.apache.org/r/55617/diff/
>
>
> Testing
> -------
>
> Manual testing:
> * create cluster via blueprint
> * verify `*_config.json` is created for client components whose installation finished before the first status command (FALCON_CLIENT and HBASE_CLIENT below)
>
> ```
> $ grep 'Adding.*command\|Executing command.*CLIENT' /var/log/ambari-agent/ambari-agent.log
> INFO 2017-01-17 13:00:42,495 Controller.py:248 - Adding 39 commands. Heartbeat id = 15
> INFO 2017-01-17 13:00:53,138 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 5 for role = FALCON_CLIENT of cluster TEST.
> INFO 2017-01-17 13:00:55,174 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 7 for role = HBASE_CLIENT of cluster TEST.
> INFO 2017-01-17 13:01:32,992 Controller.py:257 - Adding 8 status commands. Heartbeat id = 69
> INFO 2017-01-17 13:01:51,245 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 11 for role = HDFS_CLIENT of cluster TEST.
> INFO 2017-01-17 13:01:53,232 ActionQueue.py:273 - Executing command with id = 4-0, taskId = 13 for role = HIVE_CLIENT of cluster TEST.
> ...
> $ ls -l --full-time /var/lib/ambari-agent/data/*_CLIENT_config*
> -rw-r--r-- 1 root root 6327 2017-01-17 13:00:54.167877626 +0000 /var/lib/ambari-agent/data/FALCON_CLIENT_config.json
> -rw-r--r-- 1 root root 6327 2017-01-17 13:00:56.496747403 +0000 /var/lib/ambari-agent/data/HBASE_CLIENT_config.json
> -rw-r--r-- 1 root root 6327 2017-01-17 13:01:52.317955884 +0000 /var/lib/ambari-agent/data/HDFS_CLIENT_config.json
> -rw-r--r-- 1 root root 6327 2017-01-17 13:01:54.465860199 +0000 /var/lib/ambari-agent/data/HIVE_CLIENT_config.json
> ```
>
> Unit tests:
>
> ```
> $ mvn -pl ambari-agent -DskipSurefireTests test
> ...
> Ran 453 tests in 13.271s
>
> OK
> ...
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 156 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>