You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Technoboy- (via GitHub)" <gi...@apache.org> on 2023/12/11 11:14:12 UTC
[PR] [fix][perf] Fix PerformanceProducer send count error [pulsar]
Technoboy- opened a new pull request, #21706:
URL: https://github.com/apache/pulsar/pull/21706
Fixes #21703
### Motivation
The root cause is that we increase the count no matter the send error occurs.
```
2023-12-07T06:50:49,933 - INFO - [docker-java-stream-1337430181:DockerUtils$2@252] - DOCKER.exec(PerfToolTest-ianwu-zookeeper:bin/pulsar-perf produce -u pulsar://pulsar-proxy-pulsar-proxy:6650 -m 50 persistent://public/ns-hdannumd/testConsume-xwgdqllc-1701931838074): STDOUT: 2023-12-07T06:50:49,933+0000 [Thread-0] INFO org.apache.pulsar.testclient.PerformanceProducer - Aggregated throughput stats --- 49 records sent --- 4.895 msg/s --- 0.038 Mbit/s
2023-12-07T06:50:43,602 - INFO - [docker-java-stream-1337430181:DockerUtils$2@252] - DOCKER.exec(PerfToolTest-ianwu-zookeeper:bin/pulsar-perf produce -u pulsar://pulsar-proxy-pulsar-proxy:6650 -m 50 persistent://public/ns-hdannumd/testConsume-xwgdqllc-1701931838074): STDOUT: 2023-12-07T06:50:43,594+0000 [pulsar-client-io-2-1] WARN org.apache.pulsar.testclient.PerformanceProducer - Write message error with exception
```
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix PerformanceProducer send count error [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #21706:
URL: https://github.com/apache/pulsar/pull/21706#issuecomment-1851196783
> Is it possible to add a unit test?
The test has been covered by PerfToolTest.testConsume, only makes it flaky before this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix PerformanceProducer send count error [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21706:
URL: https://github.com/apache/pulsar/pull/21706#issuecomment-1850098669
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21706?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#21706](https://app.codecov.io/gh/apache/pulsar/pull/21706?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (77856a8) into [master](https://app.codecov.io/gh/apache/pulsar/commit/495b141c7bebc0356297546e9db88c9e087f5039?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (495b141) will **increase** coverage by `36.62%`.
> Report is 1 commits behind head on master.
> The diff coverage is `n/a`.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/21706?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21706 +/- ##
=============================================
+ Coverage 36.75% 73.38% +36.62%
- Complexity 12271 32767 +20496
=============================================
Files 1717 1893 +176
Lines 131197 140742 +9545
Branches 14339 15505 +1166
=============================================
+ Hits 48220 103281 +55061
+ Misses 76596 29354 -47242
- Partials 6381 8107 +1726
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21706/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21706/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.12% <ø> (+0.01%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21706/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.67% <ø> (-0.11%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21706/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.67% <ø> (+40.80%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1464 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21706/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix PerformanceProducer send count error [pulsar]
Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui merged PR #21706:
URL: https://github.com/apache/pulsar/pull/21706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org