You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2017/05/10 17:27:42 UTC

[trafficserver] branch master updated: Coverity 1021706: Init members

This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  e55964b   Coverity 1021706: Init members
e55964b is described below

commit e55964b285c21bbf994f6007d8708bc896d53c92
Author: Leif Hedstrom <zw...@apache.org>
AuthorDate: Wed May 10 11:07:18 2017 -0400

    Coverity 1021706: Init members
---
 proxy/SocksProxy.cc | 35 +++++++++++------------------------
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/proxy/SocksProxy.cc b/proxy/SocksProxy.cc
index b7bd1d7..fcda651 100644
--- a/proxy/SocksProxy.cc
+++ b/proxy/SocksProxy.cc
@@ -56,20 +56,8 @@ struct SocksProxy : public Continuation {
     SOCKS_ERROR,
   };
 
-  SocksProxy()
-    : Continuation(),
-      clientVC(nullptr),
-      clientVIO(nullptr),
-      buf(nullptr),
-      timeout(nullptr),
-      auth_handler(nullptr),
-      version(0),
-      state(SOCKS_INIT),
-      recursion(0),
-      pending_action(nullptr)
-  {
-  }
   ~SocksProxy() override {}
+
   // int startEvent(int event, void * data);
   int mainEvent(int event, void *data);
   int setupHttpRequest(unsigned char *p);
@@ -81,20 +69,19 @@ struct SocksProxy : public Continuation {
   void free();
 
 private:
-  NetVConnection *clientVC;
-  VIO *clientVIO;
-
-  MIOBuffer *buf;
-  IOBufferReader *reader;
-  Event *timeout;
+  NetVConnection *clientVC = nullptr;
+  VIO *clientVIO           = nullptr;
 
-  SocksAuthHandler auth_handler;
+  MIOBuffer *buf         = nullptr;
+  IOBufferReader *reader = nullptr;
+  Event *timeout         = nullptr;
 
-  unsigned char version;
+  SocksAuthHandler auth_handler = nullptr;
+  Action *pending_action        = nullptr;
 
-  int state;
-  int recursion;
-  Action *pending_action;
+  unsigned char version = 0;
+  int state             = SOCKS_INIT;
+  int recursion         = 0;
 };
 
 ClassAllocator<SocksProxy> socksProxyAllocator("socksProxyAllocator");

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].