You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/03 14:44:23 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #11002:
[FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle
directories
gaoyunhaii opened a new pull request #11002: [FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle directories
URL: https://github.com/apache/flink/pull/11002
## What is the purpose of the change
This PR picks [pull-10736](https://github.com/apache/flink/pull/10736) to release-1.10.
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11002:
[FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle
directories
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11002: [FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle directories
URL: https://github.com/apache/flink/pull/11002#issuecomment-581466135
<!--
Meta data
Hash:9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147221000 TriggerType:PUSH TriggerID:9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a
Hash:9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4789 TriggerType:PUSH TriggerID:9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a
-->
## CI report:
* 9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147221000) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4789)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11002:
[FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle
directories
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11002: [FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle directories
URL: https://github.com/apache/flink/pull/11002#issuecomment-581466135
<!--
Meta data
Hash:9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147221000 TriggerType:PUSH TriggerID:9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a
Hash:9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4789 TriggerType:PUSH TriggerID:9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a
-->
## CI report:
* 9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147221000) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4789)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11002: [FLINK-15010][Network]
Add shutdown hook to ensure cleanup netty shuffle directories
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11002: [FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle directories
URL: https://github.com/apache/flink/pull/11002#issuecomment-581449107
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a (Mon Feb 03 14:47:39 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11002: [FLINK-15010][Network]
Add shutdown hook to ensure cleanup netty shuffle directories
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11002: [FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle directories
URL: https://github.com/apache/flink/pull/11002#issuecomment-581466135
<!--
Meta data
Hash:9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a
-->
## CI report:
* 9073733fc0ba2acbdaf0d532dd8afc9bdb1b610a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW merged pull request #11002:
[FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle
directories
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #11002: [FLINK-15010][Network] Add shutdown hook to ensure cleanup netty shuffle directories
URL: https://github.com/apache/flink/pull/11002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services