[GitHub] [james-project] Arsnael commented on a change in pull request #284: JAMES-2453 Remove JUNIT 4 usages in server/protocols

[GitBox <gi...@apache.org>]

Arsnael commented on a change in pull request #284:
URL: https://github.com/apache/james-project/pull/284#discussion_r553105883



##########
File path: third-party/spamassassin/src/test/java/org/apache/james/spamassassin/mock/MockSpamdExtension.java
##########
@@ -23,25 +23,29 @@
 import java.util.concurrent.Executors;
 
 import org.apache.james.util.concurrent.NamedThreadFactory;
+import org.junit.jupiter.api.extension.AfterEachCallback;
+import org.junit.jupiter.api.extension.BeforeAllCallback;
+import org.junit.jupiter.api.extension.BeforeEachCallback;
+import org.junit.jupiter.api.extension.ExtensionContext;
 import org.junit.rules.ExternalResource;
 
-public class MockSpamdTestRule extends ExternalResource {
+public class MockSpamdExtension implements AfterEachCallback, BeforeEachCallback {

Review comment:
       Not this one, it's an extension declaration that will be used in oither Test classes `SpamAssassinTest` and `SpamAssassinHandlerTest` :) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org