[GitHub] [hadoop] mackrorysd commented on a change in pull request #951: HADOOP-15183. S3Guard store becomes inconsistent after partial failure of rename

[GitBox <gi...@apache.org>]

mackrorysd commented on a change in pull request #951: HADOOP-15183. S3Guard store becomes inconsistent after partial failure of rename
URL: https://github.com/apache/hadoop/pull/951#discussion_r293599503
 
 

 ##########
 File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3GuardTool.java
 ##########
 @@ -1134,16 +1147,19 @@ public int run(String[] args, PrintStream out)
       }
       String s3Path = paths.get(0);
       CommandFormat commands = getCommandFormat();
+      URI fsURI = toUri(s3Path);
 
       // check if UNGUARDED_FLAG is passed and use NullMetadataStore in
       // config to avoid side effects like creating the table if not exists
+      Configuration conf0 = getConf();
 
 Review comment:
   Please rename this to unguardedConf or something like that

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org