You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "dhruba borthakur (Created) (JIRA)" <ji...@apache.org> on 2011/12/09 09:46:41 UTC

[jira] [Created] (HBASE-4989) Metrics to measure sequential reads and random reads separately

Metrics to measure sequential reads and random reads separately
---------------------------------------------------------------

                 Key: HBASE-4989
                 URL: https://issues.apache.org/jira/browse/HBASE-4989
             Project: HBase
          Issue Type: Improvement
          Components: regionserver
            Reporter: dhruba borthakur
            Assignee: dhruba borthakur
            Priority: Minor


HBase does sequential reads for compactions and positional random reads for satisfying user's queries. It would be nice if we can measure their latencies separately. It is mostly the random reads that dominate a transactional workload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4989) Metrics to measure sequential reads and random reads separately

Posted by "Phabricator (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272578#comment-13272578 ] 

Phabricator commented on HBASE-4989:
------------------------------------

dhruba has closed the revision "[jira] [HBASE-4989] Metrics to measure sequential reads and random reads separately".

REVISION DETAIL
  https://reviews.facebook.net/D693

To: stack, todd, Kannan, khemani, dhruba
Cc: JIRA, todd, stack

                
> Metrics to measure sequential reads and random reads separately
> ---------------------------------------------------------------
>
>                 Key: HBASE-4989
>                 URL: https://issues.apache.org/jira/browse/HBASE-4989
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: metrics1.txt
>
>
> HBase does sequential reads for compactions and positional random reads for satisfying user's queries. It would be nice if we can measure their latencies separately. It is mostly the random reads that dominate a transactional workload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4989) Metrics to measure sequential reads and random reads separately

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167898#comment-13167898 ] 

Hudson commented on HBASE-4989:
-------------------------------

Integrated in HBase-TRUNK #2540 (See [https://builds.apache.org/job/HBase-TRUNK/2540/])
    HBASE-4989 Metrics to measure sequential reads and random reads separately

stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

                
> Metrics to measure sequential reads and random reads separately
> ---------------------------------------------------------------
>
>                 Key: HBASE-4989
>                 URL: https://issues.apache.org/jira/browse/HBASE-4989
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: metrics1.txt
>
>
> HBase does sequential reads for compactions and positional random reads for satisfying user's queries. It would be nice if we can measure their latencies separately. It is mostly the random reads that dominate a transactional workload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4989) Metrics to measure sequential reads and random reads separately

Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165958#comment-13165958 ] 

dhruba borthakur commented on HBASE-4989:
-----------------------------------------

Code here : https://reviews.facebook.net/D693
                
> Metrics to measure sequential reads and random reads separately
> ---------------------------------------------------------------
>
>                 Key: HBASE-4989
>                 URL: https://issues.apache.org/jira/browse/HBASE-4989
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>
> HBase does sequential reads for compactions and positional random reads for satisfying user's queries. It would be nice if we can measure their latencies separately. It is mostly the random reads that dominate a transactional workload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4989) Metrics to measure sequential reads and random reads separately

Posted by "dhruba borthakur (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HBASE-4989:
------------------------------------

    Attachment: metrics1.txt

Patchfor trunk.
                
> Metrics to measure sequential reads and random reads separately
> ---------------------------------------------------------------
>
>                 Key: HBASE-4989
>                 URL: https://issues.apache.org/jira/browse/HBASE-4989
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: metrics1.txt
>
>
> HBase does sequential reads for compactions and positional random reads for satisfying user's queries. It would be nice if we can measure their latencies separately. It is mostly the random reads that dominate a transactional workload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4989) Metrics to measure sequential reads and random reads separately

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167381#comment-13167381 ] 

Hadoop QA commented on HBASE-4989:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12506971/metrics1.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -160 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 75 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestInstantSchemaChange
                  org.apache.hadoop.hbase.client.TestAdmin

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/487//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/487//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/487//console

This message is automatically generated.
                
> Metrics to measure sequential reads and random reads separately
> ---------------------------------------------------------------
>
>                 Key: HBASE-4989
>                 URL: https://issues.apache.org/jira/browse/HBASE-4989
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: metrics1.txt
>
>
> HBase does sequential reads for compactions and positional random reads for satisfying user's queries. It would be nice if we can measure their latencies separately. It is mostly the random reads that dominate a transactional workload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4989) Metrics to measure sequential reads and random reads separately

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167759#comment-13167759 ] 

Hudson commented on HBASE-4989:
-------------------------------

Integrated in HBase-TRUNK-security #29 (See [https://builds.apache.org/job/HBase-TRUNK-security/29/])
    HBASE-4989 Metrics to measure sequential reads and random reads separately

stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

                
> Metrics to measure sequential reads and random reads separately
> ---------------------------------------------------------------
>
>                 Key: HBASE-4989
>                 URL: https://issues.apache.org/jira/browse/HBASE-4989
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: metrics1.txt
>
>
> HBase does sequential reads for compactions and positional random reads for satisfying user's queries. It would be nice if we can measure their latencies separately. It is mostly the random reads that dominate a transactional workload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4989) Metrics to measure sequential reads and random reads separately

Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167642#comment-13167642 ] 

stack commented on HBASE-4989:
------------------------------

Oh, the above hadoop-qa failures were because of 'too many files' -- unrelated to this patch.
                
> Metrics to measure sequential reads and random reads separately
> ---------------------------------------------------------------
>
>                 Key: HBASE-4989
>                 URL: https://issues.apache.org/jira/browse/HBASE-4989
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: metrics1.txt
>
>
> HBase does sequential reads for compactions and positional random reads for satisfying user's queries. It would be nice if we can measure their latencies separately. It is mostly the random reads that dominate a transactional workload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4989) Metrics to measure sequential reads and random reads separately

Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-4989:
-------------------------

       Resolution: Fixed
    Fix Version/s: 0.94.0
     Hadoop Flags: Incompatible change,Reviewed  (was: Incompatible change)
           Status: Resolved  (was: Patch Available)

Applied to trunk.  Thanks for patch Dhruba.
                
> Metrics to measure sequential reads and random reads separately
> ---------------------------------------------------------------
>
>                 Key: HBASE-4989
>                 URL: https://issues.apache.org/jira/browse/HBASE-4989
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: metrics1.txt
>
>
> HBase does sequential reads for compactions and positional random reads for satisfying user's queries. It would be nice if we can measure their latencies separately. It is mostly the random reads that dominate a transactional workload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4989) Metrics to measure sequential reads and random reads separately

Posted by "dhruba borthakur (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HBASE-4989:
------------------------------------

    Release Note: The metric fsReadLatency records the number of sequential reads. The metric fsPreadLatency records the number of random reads.
    Hadoop Flags: Incompatible change
          Status: Patch Available  (was: Open)
    
> Metrics to measure sequential reads and random reads separately
> ---------------------------------------------------------------
>
>                 Key: HBASE-4989
>                 URL: https://issues.apache.org/jira/browse/HBASE-4989
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>            Priority: Minor
>         Attachments: metrics1.txt
>
>
> HBase does sequential reads for compactions and positional random reads for satisfying user's queries. It would be nice if we can measure their latencies separately. It is mostly the random reads that dominate a transactional workload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira