You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2016/01/29 22:50:26 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-374 support schedule messag...
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/362
ARTEMIS-374 support schedule messages on LVQ
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis LVQ2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #362
----
commit d54739239bac05f82e4599f9e6936d9814ad0c86
Author: jbertram <jb...@apache.org>
Date: 2016-01-27T22:15:59Z
ARTEMIS-374 support schedule messages on LVQ
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-374 support schedule messag...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/pull/362#issuecomment-178061415
I'm not following. From what I can tell in addHead() (where I need to do the check) Rreference.getScheduledDeliveryTime() will always return 0 so there's no way to differentiate scheduled messages from non-scheduled messages by using this property. Can you clarify your suggestion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-374 support schedule messag...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/362#issuecomment-178052072
Look at Reference.getDeliveryTime(). it will be set to 0 during the Scheduling handler. It seems that's what you need, no need for any other property.
if (getDeliveryTime()==0).. go directly to the head.. same as if it had your property (I think)
I don't see a need for a new property
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-374 support schedule messag...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/362#issuecomment-178063508
@jbertram it's set during routing on PostOfficeImpl.
it should be set by the time you get there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-374 support schedule messag...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/362
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-374 support schedule messag...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/pull/362#issuecomment-178012905
I need some way to differentiate messages that are put on the head of the queue by the scheduler and those that aren't because they need to be treated differently (notice the new 'if' block in addHead()). A message property seemed the simplest way to do that, but I'm open to other possibilities. Do you have any suggestions here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---