You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/06/24 01:08:47 UTC
[jira] [Created] (HDFS-2104) 1073: Add a flag to 2NN to format its
checkpoint dirs on startup
1073: Add a flag to 2NN to format its checkpoint dirs on startup
----------------------------------------------------------------
Key: HDFS-2104
URL: https://issues.apache.org/jira/browse/HDFS-2104
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Todd Lipcon
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2104) 1073: Add a flag to 2NN to format its
checkpoint dirs on startup
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-2104:
------------------------------
Attachment: hdfs-2104.txt
updated patch w/ the above change
> 1073: Add a flag to 2NN to format its checkpoint dirs on startup
> ----------------------------------------------------------------
>
> Key: HDFS-2104
> URL: https://issues.apache.org/jira/browse/HDFS-2104
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Todd Lipcon
> Attachments: hdfs-2104.txt, hdfs-2104.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2104) 1073: Add a flag to 2NN to format its
checkpoint dirs on startup
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HDFS-2104.
-------------------------------
Resolution: Fixed
Fix Version/s: Edit log branch (HDFS-1073)
Assignee: Todd Lipcon
Release Note: The SecondaryNameNode now has a command line option "-format" which must be used after the primary NameNode is reformatted, or if the same SecondaryNameNode is reconfigured to talk to a different cluster.
Hadoop Flags: [Reviewed]
> 1073: Add a flag to 2NN to format its checkpoint dirs on startup
> ----------------------------------------------------------------
>
> Key: HDFS-2104
> URL: https://issues.apache.org/jira/browse/HDFS-2104
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: hdfs-2104.txt, hdfs-2104.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2104) 1073: Add a flag to 2NN to format
its checkpoint dirs on startup
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065480#comment-13065480 ]
Todd Lipcon commented on HDFS-2104:
-----------------------------------
Will make the following change:
{code}
@@ -737,7 +737,7 @@ public class SecondaryNameNode implements Runnable {
try {
opts.parse(argv);
} catch (ParseException pe) {
- LOG.warn(pe);
+ LOG.error(pe.getMessage());
opts.usage();
return null;
}
{code}
Manual testing of this change shows:
{noformat}
todd@todd-w510:~/git/hadoop-common/hdfs$ ./bin/hdfs secondarynamenode -fdsa
11/07/14 12:18:46 ERROR namenode.SecondaryNameNode: Unrecognized option: -fdsa
usage: secondarynamenode
-checkpoint <force> checkpoint on startup
-format format the local storage during startup
-geteditsize return the number of uncheckpointed transactions on
the NameNode
{noformat}
Since this is a trivial difference from the first patch I'll commit with this fix in place.
> 1073: Add a flag to 2NN to format its checkpoint dirs on startup
> ----------------------------------------------------------------
>
> Key: HDFS-2104
> URL: https://issues.apache.org/jira/browse/HDFS-2104
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Todd Lipcon
> Attachments: hdfs-2104.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2104) 1073: Add a flag to 2NN to format
its checkpoint dirs on startup
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065663#comment-13065663 ]
Hudson commented on HDFS-2104:
------------------------------
Integrated in Hadoop-Hdfs-1073-branch #9 (See [https://builds.apache.org/job/Hadoop-Hdfs-1073-branch/9/])
HDFS-2104. Add a flag to the 2NN to format its checkpoint dirs on startup. Contributed by Todd Lipcon.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146863
Files :
* /hadoop/common/branches/HDFS-1073/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/branches/HDFS-1073/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
* /hadoop/common/branches/HDFS-1073/hdfs/CHANGES.HDFS-1073.txt
> 1073: Add a flag to 2NN to format its checkpoint dirs on startup
> ----------------------------------------------------------------
>
> Key: HDFS-2104
> URL: https://issues.apache.org/jira/browse/HDFS-2104
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: hdfs-2104.txt, hdfs-2104.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2104) 1073: Add a flag to 2NN to format
its checkpoint dirs on startup
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065486#comment-13065486 ]
Eli Collins commented on HDFS-2104:
-----------------------------------
+1 updated patch looks good
> 1073: Add a flag to 2NN to format its checkpoint dirs on startup
> ----------------------------------------------------------------
>
> Key: HDFS-2104
> URL: https://issues.apache.org/jira/browse/HDFS-2104
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: hdfs-2104.txt, hdfs-2104.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2104) 1073: Add a flag to 2NN to format its
checkpoint dirs on startup
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-2104:
------------------------------
Attachment: hdfs-2104.txt
Added a -format flag. While I was at it, I replaced the ad-hoc parsing code with Commons-CLI.
I elected _not_ to have it ask for confirmation, since this is only formatting the secondary and not a primary. Our old behavior was basically to overwrite the local image anyway, so this isn't a regression in safety.
> 1073: Add a flag to 2NN to format its checkpoint dirs on startup
> ----------------------------------------------------------------
>
> Key: HDFS-2104
> URL: https://issues.apache.org/jira/browse/HDFS-2104
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Todd Lipcon
> Attachments: hdfs-2104.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2104) 1073: Add a flag to 2NN to format
its checkpoint dirs on startup
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064911#comment-13064911 ]
Eli Collins commented on HDFS-2104:
-----------------------------------
+1
Nit: seems like SNN#parseArgs should LOG.error for parse exceptions, does this log make it to the CLI ouput? If not then users just see the usage info and not the actual error.
> 1073: Add a flag to 2NN to format its checkpoint dirs on startup
> ----------------------------------------------------------------
>
> Key: HDFS-2104
> URL: https://issues.apache.org/jira/browse/HDFS-2104
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Todd Lipcon
> Attachments: hdfs-2104.txt
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira