[GitHub] [airflow] potiuk commented on a change in pull request #11262: The bats script for CI image is now placed in the docker folder

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #11262:
URL: https://github.com/apache/airflow/pull/11262#discussion_r499187247



##########
File path: Dockerfile.ci
##########
@@ -216,7 +216,7 @@ RUN mkdir -p /opt/bats/lib/bats-file \
 RUN echo "export PATH=/opt/bats/bin:${PATH}" >> /root/.bashrc
 
 # Additional scripts for managing BATS addons
-COPY scripts/ci/dockerfiles/bats/load.bash /opt/bats/lib/

Review comment:
       No. It is needed in the "local" bats. It's a bit of duplication (but very little) but it helps to keep stuff in order. The scripts in "ci" are those that are used in the host, where the scripts in "docker" are needed by the Docker image to be used as part of the build context.
   
   The problem is that in the workflow run the "ci" scripts for security come always from master (so that no-one can abuse the GITHUB_TOKEN with write access, but the Dockerfile.ci and all the stuff that is needed to build the Docker image needs to come from the PR. 
   
   I know it's not straightforward :( . But this way we have huge optimisations when building the image only once in workflow_run,




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org