You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/28 13:26:08 UTC

[GitHub] [incubator-nuttx] saramonteiro edited a comment on pull request #1904: xtensa/ESP32: Fixed the type of cpuint variables in esp32_emac.c esp32_i2c.c esp32_spi.c esp32_spi_slave.c

saramonteiro edited a comment on pull request #1904:
URL: https://github.com/apache/incubator-nuttx/pull/1904#issuecomment-700004965


   @btashton Thanks for your considerations!
   I'd rather the` int `option instead of using a temp variable. I think it will be standardized with the other arches. I will take a look at other drivers to make sure this change will be done in all drivers. And I also agree with you that `esp32_detach` should answer a negative return.
   Thanks for such attention and these suggestions! 
   I will do the necessary changes and commit it again.
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org