You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "dsmiley (via GitHub)" <gi...@apache.org> on 2026/07/20 05:25:08 UTC
[PR] SOLR-18310: opentelemetry module should not ship Netty JARs [solr]
dsmiley opened a new pull request, #4646:
URL: https://github.com/apache/solr/pull/4646
https://issues.apache.org/jira/browse/SOLR-18310
(READ THE JIRA)
_Implemented with AI of course_
I tested with claude using Jaeger to ensure this actually worked. It was useful to uncover a security manager config setting that was needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18310: opentelemetry module should not ship Netty JARs [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #4646:
URL: https://github.com/apache/solr/pull/4646#issuecomment-5026931193
Sharing a prompt & response with AI with the wider audience here:
**Context:** Historically, metrics and tracing were backed by different mechanisms. Now it's basically all OpenTelemetry. Our documentation and configuration seems too bifurcated nowadays. Of course we still need to discuss metrics separately from tracing, but there's a need IMO for a documentation page just for OTEL, and perhaps configuration too. WDYT? (not acting on this now, just capturing the thought)
---
Agreed — this PR ends up duplicating the same gRPC-JARs caveat in both `distributed-tracing.adoc` and `metrics-reporting.adoc`, which is a symptom of the split. My take: don't fully merge them (tracing and metrics still have genuinely different audiences and mental models), but a single `opentelemetry.adoc` landing page covering the shared stuff once — module enablement, the JAR/dependency story, gRPC-vs-HTTP tradeoffs — with tracing and metrics as subsections or linked child pages, would kill the duplication without pretending they're the same feature.
The deeper wrinkle worth flagging: it's not just docs that are split, the *configuration mechanisms* are too — tracing goes through real OTEL SDK autoconfigure (`OTEL_EXPORTER_OTLP_*` env vars), while metrics uses bespoke Solr system properties (`solr.metrics.otlpExporter*`) that don't follow OTEL conventions at all. A unified doc page would make that inconsistency more visible, which might be a feature (motivates fixing it) or a distraction (raises scope) depending on appetite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18310: opentelemetry module should not ship Netty JARs [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #4646:
URL: https://github.com/apache/solr/pull/4646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18310: opentelemetry module should not ship Netty JARs [solr]
Posted by "mlbiscoc (via GitHub)" <gi...@apache.org>.
mlbiscoc commented on code in PR #4646:
URL: https://github.com/apache/solr/pull/4646#discussion_r3614885655
##########
solr/core/src/java/org/apache/solr/metrics/otel/MetricExporterFactory.java:
##########
@@ -25,7 +25,7 @@ public interface MetricExporterFactory {
Boolean.parseBoolean(EnvUtils.getProperty("solr.metrics.otlpExporterEnabled", "false"));
public static final String OTLP_EXPORTER_PROTOCOL =
- EnvUtils.getProperty("solr.metrics.otlpExporterProtocol", "grpc");
+ EnvUtils.getProperty("solr.metrics.otlpExporterProtocol", "http");
Review Comment:
The default is grpc but I am ok with http.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18310: opentelemetry module should not ship Netty JARs [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #4646:
URL: https://github.com/apache/solr/pull/4646#discussion_r3612203751
##########
changelog/unreleased/SOLR-18310-otel-jdk-sender.yml:
##########
@@ -0,0 +1,9 @@
+title: >
+ Removed OkHttp, gRPC, and Netty jars from the opentelemetry module. The OTLP/http protocol still
+ works but no longer uses additional dependencies.
+type: dependency_update
Review Comment:
Not a typical dependency_update usage (isn't an upgrade) but why not use it here.
CC @janhoy
##########
solr/core/src/java/org/apache/solr/metrics/otel/MetricExporterFactory.java:
##########
@@ -25,7 +25,7 @@ public interface MetricExporterFactory {
Boolean.parseBoolean(EnvUtils.getProperty("solr.metrics.otlpExporterEnabled", "false"));
public static final String OTLP_EXPORTER_PROTOCOL =
- EnvUtils.getProperty("solr.metrics.otlpExporterProtocol", "grpc");
+ EnvUtils.getProperty("solr.metrics.otlpExporterProtocol", "http");
Review Comment:
OTLP http/protobuf is widely supported OOTB on recipients AFAICT. I suspect users won't notice this change, but it's not something to withhold from a changelog.
I do expect a there would be a performance difference, albeit not much for a reasonably performant http stack (I think JDK HttpClient is such).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18310: opentelemetry module should not ship Netty JARs [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #4646:
URL: https://github.com/apache/solr/pull/4646#issuecomment-5026182533
I think the DX is pretty good if someone chooses grpc:
java.lang.IllegalStateException: No GrpcSenderProvider found on classpath. Please add dependency on
opentelemetry-exporter-sender-okhttp or opentelemetry-exporter-sender-grpc-upstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18310: opentelemetry module should not ship Netty JARs [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #4646:
URL: https://github.com/apache/solr/pull/4646#discussion_r3614082145
##########
solr/core/src/java/org/apache/solr/metrics/otel/MetricExporterFactory.java:
##########
@@ -25,7 +25,7 @@ public interface MetricExporterFactory {
Boolean.parseBoolean(EnvUtils.getProperty("solr.metrics.otlpExporterEnabled", "false"));
public static final String OTLP_EXPORTER_PROTOCOL =
- EnvUtils.getProperty("solr.metrics.otlpExporterProtocol", "grpc");
+ EnvUtils.getProperty("solr.metrics.otlpExporterProtocol", "http");
Review Comment:
do we know that http is the default choice in the otel world? I guess in my head I thought grpc for performacne reasons? But I'm not an expert!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org