You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/26 01:01:30 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7880: Don't schedule
dummy task
mik-laj opened a new pull request #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880
https://github.com/apache/airflow/issues/7871
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7880: Don't
schedule dummy task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880#issuecomment-604299485
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=h1) Report
> Merging [#7880](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6fd74e706e0da24da1dfcceba14600c929a36cf&el=desc) will **decrease** coverage by `0.71%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7880 +/- ##
==========================================
- Coverage 86.95% 86.23% -0.72%
==========================================
Files 927 927
Lines 44974 44977 +3
==========================================
- Hits 39107 38788 -319
- Misses 5867 6189 +322
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/dummy\_operator.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZHVtbXlfb3BlcmF0b3IucHk=) | `100.00% <ø> (ø)` | |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.92% <100.00%> (+0.47%)` | :arrow_up: |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=footer). Last update [a6fd74e...d851a2f](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7880: Don't schedule dummy
task
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880#issuecomment-604299485
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=h1) Report
> Merging [#7880](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6fd74e706e0da24da1dfcceba14600c929a36cf&el=desc) will **decrease** coverage by `0.71%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7880 +/- ##
==========================================
- Coverage 86.95% 86.23% -0.72%
==========================================
Files 927 927
Lines 44974 44977 +3
==========================================
- Hits 39107 38788 -319
- Misses 5867 6189 +322
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/dummy\_operator.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZHVtbXlfb3BlcmF0b3IucHk=) | `100.00% <ø> (ø)` | |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.92% <100.00%> (+0.47%)` | :arrow_up: |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=footer). Last update [a6fd74e...d851a2f](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7880:
Don't schedule dummy task
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880#discussion_r398553868
##########
File path: airflow/operators/dummy_operator.py
##########
@@ -24,6 +24,9 @@ class DummyOperator(BaseOperator):
"""
Operator that does literally nothing. It can be used to group tasks in a
DAG.
+
+ The task that uses this operator is automatically marked as successfully completed by the scheduler
Review comment:
I updated the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] eladkal commented on a change in pull request #7880:
Don't schedule dummy task
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880#discussion_r398466881
##########
File path: airflow/operators/dummy_operator.py
##########
@@ -24,6 +24,9 @@ class DummyOperator(BaseOperator):
"""
Operator that does literally nothing. It can be used to group tasks in a
DAG.
+
+ The task that uses this operator is automatically marked as successfully completed by the scheduler
Review comment:
@mik-laj This is what confused me.
Maybe better saying something like:
The task is evaluated by the scheduler but never processed by the executor
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7880: Don't schedule dummy
task
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7880: Don't schedule dummy
task
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880#issuecomment-604318681
But the trigger rules will still be respected. I added this code when the task is to be marked for execution by the scheduler and the trigger rules have already been checked. All callbacks will also be executed, because when the task has callbacks, it will still be passed to the scheduler.
This optimization applies only to cases when the task has no callbacks and when the decision to execute it has been made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] eladkal edited a comment on issue #7880: Don't schedule
dummy task
Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on issue #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880#issuecomment-604309597
I think it's a good idea that `DummyOperator` won't be scheduled but I don't agree with the statement "DummyOperator doesn't actually do work".
For example:
If the Dummy is marked always as success what will happen to cases where `DummyOperator` is used with trigger rules for some flows ?
Example:
```
final = DummyOperator(
dag=dag,
task_id="error_check",
trigger_rule=TriggerRule.ONE_FAILED
)
[task1, task2, task3] >> final
```
In this case marking `final` as `FAILED` result in failure of the DAG which invoke `on_failure_callback`.
Also it's possible in the above example that there is ExternalSensor from `dag2` on `final` so it's important that `final` won't be marked as `SUCCESS` automatically.
Probably just need to update `Updating.md` alerting change of behavior as DummyOperator will not longer honor `trigger_rule`. Maybe even not allowing users to overwrite the default `trigger_rule` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] eladkal commented on issue #7880: Don't schedule dummy
task
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880#issuecomment-604309597
I think it's a good idea that `DummyOperator` won't be scheduled but I don't agree with the statement "DummyOperator doesn't actually do work".
For example:
If the Dummy is marked always as success what will happen to cases where `DummyOperator` is used with trigger rules for some flows ?
Example:
```
final = DummyOperator(
dag=dag,
task_id="error_check",
trigger_rule=TriggerRule.ONE_FAILED
)
[task1, task2, task3] >> final
```
In this case marking `final` as `FAILED` result in failure of the DAG which invoke `on_failure_callback`.
Also it's possible in the above example that there is ExternalSensor from `dag2` on `final` so it's important that `final` won't be marked as `SUCCESS` automatically.
Probably just need to update `Updating.md` alerting change of behavior as DummyOperator will not longer honor `trigger_rule`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7880: Don't
schedule dummy task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880#issuecomment-604299485
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=h1) Report
> Merging [#7880](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a6fd74e706e0da24da1dfcceba14600c929a36cf&el=desc) will **decrease** coverage by `0.71%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7880 +/- ##
==========================================
- Coverage 86.95% 86.23% -0.72%
==========================================
Files 927 927
Lines 44974 44977 +3
==========================================
- Hits 39107 38788 -319
- Misses 5867 6189 +322
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/operators/dummy\_operator.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZHVtbXlfb3BlcmF0b3IucHk=) | `100.00% <ø> (ø)` | |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.92% <100.00%> (+0.47%)` | :arrow_up: |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/airflow/pull/7880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=footer). Last update [a6fd74e...d851a2f](https://codecov.io/gh/apache/airflow/pull/7880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7880: Don't
schedule dummy task
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7880: Don't schedule dummy task
URL: https://github.com/apache/airflow/pull/7880#discussion_r398483550
##########
File path: airflow/operators/dummy_operator.py
##########
@@ -24,6 +24,9 @@ class DummyOperator(BaseOperator):
"""
Operator that does literally nothing. It can be used to group tasks in a
DAG.
+
+ The task that uses this operator is automatically marked as successfully completed by the scheduler
Review comment:
Yeah. Might be worth adding!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services