[GitHub] [hbase] 2005hithlj commented on a diff in pull request #4457: HBASE-27028 Add a shell command for flushing master local region

[GitBox <gi...@apache.org>]

2005hithlj commented on code in PR #4457:
URL: https://github.com/apache/hbase/pull/4457#discussion_r885255822


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##########
@@ -2539,4 +2539,9 @@ default BalanceResponse balanceRSGroup(String groupName) throws IOException {
    */
   List<LogEntry> getLogEntries(Set<ServerName> serverNames, String logType, ServerType serverType,
     int limit, Map<String, Object> filterParams) throws IOException;
+
+  /**
+   * Force request flush master local region
+   */
+  void forceRequestFlushMasterStore() throws IOException;

Review Comment:
   If we call region.flush(true) at the master side, the changesAfterLastFlush value of MasterRegionFlusherAndCompactor will become incorrect, which may trigger an invalid flush operation.
   But we can call MasterRegionFlusherAndCompactor.requestFlush() to avoid this.
   
   Do we need to consider this situation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org