You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Martin Kraemer <Ma...@Fujitsu-Siemens.com> on 2001/11/14 14:21:06 UTC
[2.0] mod_proxy doesn't compile
> I'm going to commit this when I am done, and people can comment and make
> changes. Once this is done, I am hoping to work on the perchild MPM and
> the proxy.
Do you refer to the change in httpd.h which moved the client_socket into
the core_net_rec and broke mod_proxy? Currently it does not compile:
proxy_connect.c: In function `ap_proxy_connect_handler':
proxy_connect.c:308: structure has no member named `client_socket'
proxy_connect.c:311: structure has no member named `client_socket'
proxy_connect.c:334: structure has no member named `client_socket'
proxy_connect.c:362: structure has no member named `client_socket'
proxy_connect.c:375: structure has no member named `client_socket'
proxy_connect.c:380: structure has no member named `client_socket'
proxy_ftp.c: In function `ap_proxy_ftp_handler':
proxy_ftp.c:748: warning: implicit declaration of function `ap_new_connection'
proxy_ftp.c:748: warning: assignment makes pointer from integer without a cast
proxy_ftp.c:760: structure has no member named `client_socket'
proxy_ftp.c:1551: warning: assignment makes pointer from integer without a cast
proxy_ftp.c:1600: structure has no member named `client_socket'
proxy_ftp.c:1635: structure has no member named `client_socket'
proxy_http.c: In function `ap_proxy_http_create_connection':
proxy_http.c:305: structure has no member named `client_socket'
proxy_http.c:320: structure has no member named `client_socket'
proxy_http.c:415: warning: implicit declaration of function `ap_new_connection'
proxy_http.c:416: warning: assignment makes pointer from integer without a cast
Is there an accessor which can return the open socket, or how
can mod_proxy get raw access to it?
Martin
--
<Ma...@Fujitsu-Siemens.com> | Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-47655 | 81730 Munich, Germany
Re: [2.0] mod_proxy doesn't compile
Posted by Justin Erenkrantz <je...@ebuilt.com>.
On Wed, Nov 14, 2001 at 02:21:06PM +0100, Martin Kraemer wrote:
> > I'm going to commit this when I am done, and people can comment and make
> > changes. Once this is done, I am hoping to work on the perchild MPM and
> > the proxy.
>
> Do you refer to the change in httpd.h which moved the client_socket into
> the core_net_rec and broke mod_proxy? Currently it does not compile:
>
> proxy_connect.c: In function `ap_proxy_connect_handler':
> proxy_connect.c:308: structure has no member named `client_socket'
[ snip, snip ]
Yup.
> Is there an accessor which can return the open socket, or how
> can mod_proxy get raw access to it?
I have no idea. -- justin
Re: [2.0] mod_proxy doesn't compile
Posted by Ryan Bloom <rb...@covalent.net>.
On Wednesday 14 November 2001 01:19 pm, Graham Leggett wrote:
> Ryan Bloom wrote:
> > But it's not just the connect stuff which goes directly to the socket.
> > All of the proxy avoids the filters for communication to the backend
> > server, which removes a useful place to do filtering.
>
> Both the ftp and http proxy use a simple filter stack to talk to the
> backend (unless it's been changed), however this stack isn't very
> configurable at the moment. The framework is there, it just needs to be
> fleshed out.
All three files, proxy_connect, proxy_http, and proxy_ftp use the client_socket
from the conn_rec. That is broken. I know they use it, because I just fixed them
all to not use it, because I removed that field. I fixed them the wrong way,
because the framework isn't correct for the proxy yet to fix them the right way.
Since a lot of people want to see the proxy compile again, and I doing a quick
hack now, and I'll be fixing the proxy module over the next week or so.
Ryan
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
Re: [2.0] mod_proxy doesn't compile
Posted by Graham Leggett <mi...@sharp.fm>.
Ryan Bloom wrote:
> But it's not just the connect stuff which goes directly to the socket. All of
> the proxy avoids the filters for communication to the backend server, which
> removes a useful place to do filtering.
Both the ftp and http proxy use a simple filter stack to talk to the
backend (unless it's been changed), however this stack isn't very
configurable at the moment. The framework is there, it just needs to be
fleshed out.
Regards,
Graham
--
-----------------------------------------
minfrin@sharp.fm "There's a moon
over Bourbon Street
tonight..."
Re: [2.0] mod_proxy doesn't compile
Posted by Ryan Bloom <rb...@covalent.net>.
On Wednesday 14 November 2001 12:49 pm, Graham Leggett wrote:
> Ryan Bloom wrote:
> > > proxy_connect.c: In function `ap_proxy_connect_handler':
> > > proxy_connect.c:308: structure has no member named `client_socket'
>
> [snip]
>
> > I have removed half of these, but the other half are proving tricky.
> > Should have something soon. The problem is that the proxy needs to be
> > able to read from either the client or server, and it doesn't know which
> > is going to be sending data. To get around this, the proxy uses apr_poll
> > to determine which is sending data. Unfortunately, it doesn't have the
> > socket anymore to do a poll on. I have a few thoughts, but I don't know
> > how well they will work.
> >
> > The thing that really bothers me though, is that our proxy is purposely
> > not using filters for a lot of output. I am fixing that.
>
> The proxy_connect stuff is purposefully "passthrough" by nature, which
> goes against the whole filters idea (where filters are designed to
> change data that passes by). I didn't tackle trying to implement connect
> with filters as I didn't understand filters well enough at that stage
> for it to work...
But it's not just the connect stuff which goes directly to the socket. All of
the proxy avoids the filters for communication to the backend server, which
removes a useful place to do filtering.
Ryan
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
Re: [2.0] mod_proxy doesn't compile
Posted by Graham Leggett <mi...@sharp.fm>.
Ryan Bloom wrote:
> > proxy_connect.c: In function `ap_proxy_connect_handler':
> > proxy_connect.c:308: structure has no member named `client_socket'
[snip]
>
> I have removed half of these, but the other half are proving tricky. Should
> have something soon. The problem is that the proxy needs to be able to read
> from either the client or server, and it doesn't know which is going to be
> sending data. To get around this, the proxy uses apr_poll to determine which
> is sending data. Unfortunately, it doesn't have the socket anymore to do a poll
> on. I have a few thoughts, but I don't know how well they will work.
>
> The thing that really bothers me though, is that our proxy is purposely
> not using filters for a lot of output. I am fixing that.
The proxy_connect stuff is purposefully "passthrough" by nature, which
goes against the whole filters idea (where filters are designed to
change data that passes by). I didn't tackle trying to implement connect
with filters as I didn't understand filters well enough at that stage
for it to work...
Regards,
Graham
--
-----------------------------------------
minfrin@sharp.fm "There's a moon
over Bourbon Street
tonight..."
Re: [2.0] mod_proxy doesn't compile
Posted by Ryan Bloom <rb...@covalent.net>.
On Wednesday 14 November 2001 05:21 am, Martin Kraemer wrote:
> > I'm going to commit this when I am done, and people can comment and make
> > changes. Once this is done, I am hoping to work on the perchild MPM and
> > the proxy.
>
> Do you refer to the change in httpd.h which moved the client_socket into
> the core_net_rec and broke mod_proxy? Currently it does not compile:
>
> proxy_connect.c: In function `ap_proxy_connect_handler':
> proxy_connect.c:308: structure has no member named `client_socket'
> proxy_connect.c:311: structure has no member named `client_socket'
> proxy_connect.c:334: structure has no member named `client_socket'
> proxy_connect.c:362: structure has no member named `client_socket'
> proxy_connect.c:375: structure has no member named `client_socket'
> proxy_connect.c:380: structure has no member named `client_socket'
I have removed half of these, but the other half are proving tricky. Should
have something soon. The problem is that the proxy needs to be able to read
from either the client or server, and it doesn't know which is going to be
sending data. To get around this, the proxy uses apr_poll to determine which
is sending data. Unfortunately, it doesn't have the socket anymore to do a poll
on. I have a few thoughts, but I don't know how well they will work.
The thing that really bothers me though, is that our proxy is purposely
not using filters for a lot of output. I am fixing that.
Ryan
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
Re: [2.0] mod_proxy doesn't compile
Posted by Ryan Bloom <rb...@covalent.net>.
On Wednesday 14 November 2001 05:21 am, Martin Kraemer wrote:
> > I'm going to commit this when I am done, and people can comment and make
> > changes. Once this is done, I am hoping to work on the perchild MPM and
> > the proxy.
>
> Do you refer to the change in httpd.h which moved the client_socket into
> the core_net_rec and broke mod_proxy? Currently it does not compile:
>
> proxy_connect.c: In function `ap_proxy_connect_handler':
> proxy_connect.c:308: structure has no member named `client_socket'
> proxy_connect.c:311: structure has no member named `client_socket'
> proxy_connect.c:334: structure has no member named `client_socket'
> proxy_connect.c:362: structure has no member named `client_socket'
> proxy_connect.c:375: structure has no member named `client_socket'
> proxy_connect.c:380: structure has no member named `client_socket'
>
> proxy_ftp.c: In function `ap_proxy_ftp_handler':
> proxy_ftp.c:748: warning: implicit declaration of function
> `ap_new_connection' proxy_ftp.c:748: warning: assignment makes pointer from
> integer without a cast proxy_ftp.c:760: structure has no member named
> `client_socket'
> proxy_ftp.c:1551: warning: assignment makes pointer from integer without a
> cast proxy_ftp.c:1600: structure has no member named `client_socket'
> proxy_ftp.c:1635: structure has no member named `client_socket'
>
> proxy_http.c: In function `ap_proxy_http_create_connection':
> proxy_http.c:305: structure has no member named `client_socket'
> proxy_http.c:320: structure has no member named `client_socket'
> proxy_http.c:415: warning: implicit declaration of function
> `ap_new_connection' proxy_http.c:416: warning: assignment makes pointer
> from integer without a cast
>
> Is there an accessor which can return the open socket, or how
> can mod_proxy get raw access to it?
mod_proxy is on my list of thiings to fix today. It shouldn't be using the socket
directly. That is a bug that just needs to be fixed.
Ryan
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------
Re: [2.0] mod_proxy doesn't compile
Posted by Graham Leggett <mi...@sharp.fm>.
Ryan Bloom wrote:
> In order to make this work, I had to put the socket in the conn_config vector,
> which is then access by the proxy. This is a hack, but it will have to do until
> I get a chance to really dig into the proxy. BTW, the FTP proxy sucks BIG
> time. It is one huge function. That makes it really hard to see how things
> are working.
Oi - the FTP proxy sucks a lot less than it did. ;)
Not so long ago someone went on a make-http-proxy-into-many-functions
mission, but noone followed up for the ftp proxy. Fixing FTP proxy is on
my todo list after my overdraft is paid off...
Regards,
Graham
--
-----------------------------------------
minfrin@sharp.fm "There's a moon
over Bourbon Street
tonight..."
Re: [2.0] mod_proxy doesn't compile
Posted by Ryan Bloom <rb...@covalent.net>.
On Wednesday 14 November 2001 05:21 am, Martin Kraemer wrote:
> > I'm going to commit this when I am done, and people can comment and make
> > changes. Once this is done, I am hoping to work on the perchild MPM and
> > the proxy.
>
> Do you refer to the change in httpd.h which moved the client_socket into
> the core_net_rec and broke mod_proxy? Currently it does not compile:
>
> proxy_connect.c: In function `ap_proxy_connect_handler':
> proxy_connect.c:308: structure has no member named `client_socket'
> proxy_connect.c:311: structure has no member named `client_socket'
> proxy_connect.c:334: structure has no member named `client_socket'
> proxy_connect.c:362: structure has no member named `client_socket'
> proxy_connect.c:375: structure has no member named `client_socket'
> proxy_connect.c:380: structure has no member named `client_socket'
>
> proxy_ftp.c: In function `ap_proxy_ftp_handler':
> proxy_ftp.c:748: warning: implicit declaration of function
> `ap_new_connection' proxy_ftp.c:748: warning: assignment makes pointer from
> integer without a cast proxy_ftp.c:760: structure has no member named
> `client_socket'
> proxy_ftp.c:1551: warning: assignment makes pointer from integer without a
> cast proxy_ftp.c:1600: structure has no member named `client_socket'
> proxy_ftp.c:1635: structure has no member named `client_socket'
>
> proxy_http.c: In function `ap_proxy_http_create_connection':
> proxy_http.c:305: structure has no member named `client_socket'
> proxy_http.c:320: structure has no member named `client_socket'
> proxy_http.c:415: warning: implicit declaration of function
> `ap_new_connection' proxy_http.c:416: warning: assignment makes pointer
> from integer without a cast
>
> Is there an accessor which can return the open socket, or how
> can mod_proxy get raw access to it?
Well, I have a fully compiling mod_proxy now. The http proxy worked as I
surfed to various web sites for about ten minutes. The connect proxy doesn't
work yet. As soon as I get that fixed, I'll commit. I'm not testing ftp, because
I don't really know how to.
In order to make this work, I had to put the socket in the conn_config vector,
which is then access by the proxy. This is a hack, but it will have to do until
I get a chance to really dig into the proxy. BTW, the FTP proxy sucks BIG
time. It is one huge function. That makes it really hard to see how things
are working.
Ryan
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------