You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/02 07:37:12 UTC
[GitHub] [iotdb] jixuan1989 opened a new pull request #2966: limit the class name length <=25 in logback
jixuan1989 opened a new pull request #2966:
URL: https://github.com/apache/iotdb/pull/2966
Currently, our log prints too many duplicated info (i.e., "org.apache.iotdb."), like:
```
n.CompactionMergeTaskPoolManager:62 - Compaction task manager started.
2021-04-01 17:08:13,893 [pool-4-IoTDB-Compaction-ServerServiceImpl-thread-3] INFO org.apache.iotdb.db.engine.compaction.level.LevelCompactionTsFileManagement:611 - root.group_44 start to filter compaction condition
2021-04-01 17:08:13,894 [pool-4-IoTDB-Compaction-ServerServiceImpl-thread-3] INFO org.apache.iotdb.db.engine.compaction.level.LevelCompactionTsFileManagement:689 - root.group_44 [Compaction] merge end time isSeq = true, consumption: 1 ms
2021-04-01 17:08:13,894 [pool-4-IoTDB-Compaction-ServerServiceImpl-thread-3] INFO org.apache.iotdb.db.engine.compaction.TsFileManagement:216 - root.group_44 no unseq files to be merged
```
Logback allows us set the maximal className length.
In this PR, I set the length <=25, see the effect:
```
2021-04-02 15:32:08,063 [main] INFO o.a.i.d.c.IoTDBDescriptor:120 - Start to read config file file:sbin/../conf/iotdb-engine.properties
2021-04-02 15:32:08,091 [main] INFO o.a.i.d.c.IoTDBDescriptor:1061 - allocateMemoryForRead = 2290719129
2021-04-02 15:32:08,091 [main] INFO o.a.i.d.c.IoTDBDescriptor:1062 - allocateMemoryForWrite = 3054292172
2021-04-02 15:32:08,091 [main] INFO o.a.i.d.c.IoTDBDescriptor:1063 - allocateMemoryForSchema = 763573043
2021-04-02 15:32:08,093 [main] INFO o.a.i.d.c.IoTDBDescriptor:251 - IoTDB enable memory control: true
2021-04-02 15:32:08,099 [main] INFO o.a.i.t.c.c.TSFileDescriptor:104 - Start to read config file sbin/../conf/iotdb-engine.properties
2021-04-02 15:32:08,102 [main] INFO o.a.i.d.metadata.MManager:178 - create system folder /Users/hxd/Documents/git/iotdb/server/target/iotdb-server-0.12.0-SNAPSHOT/sbin/../data/system/schema
2021-04-02 15:32:08,114 [main] INFO o.a.i.d.c.IoTDBConfigCheck:114 - Starting IoTDB 0.12.0-SNAPSHOT
2021-04-02 15:32:08,116 [main] INFO o.a.i.d.c.IoTDBConfigCheck:179 - /Users/hxd/Documents/git/iotdb/server/target/iotdb-server-0.12.0-SNAPSHOT/sbin/../data/system/schema/system.properties has been created.
2021-04-02 15:32:08,164 [main] WARN o.a.i.d.s.StartupChecks:38 - iotdb.jmx.port missing from iotdb-env.sh(Unix or OS X, if you use Windows, check conf/iotdb-env.bat)
2021-04-02 15:32:08,166 [main] INFO o.a.i.d.s.StartupChecks:56 - JDK veriosn is 8.
2021-04-02 15:32:08,166 [main] INFO o.a.i.db.service.IoTDB:97 - Setting up IoTDB...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 merged pull request #2966: [IOTDB-1278]limit the class name length <=25 in logback and reduce thread pool name length
Posted by GitBox <gi...@apache.org>.
jixuan1989 merged pull request #2966:
URL: https://github.com/apache/iotdb/pull/2966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2966: [IOTDB-1278]limit the class name length <=25 in logback and reduce thread pool name length
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2966:
URL: https://github.com/apache/iotdb/pull/2966#issuecomment-812482829
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2966&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100.png' alt='100.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2966&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2966&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2966&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2966&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org