You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/13 06:26:45 UTC
[GitHub] [kafka] JoelWee commented on a change in pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter
JoelWee commented on a change in pull request #8923:
URL: https://github.com/apache/kafka/pull/8923#discussion_r469722613
##########
File path: docs/streams/developer-guide/app-reset-tool.html
##########
@@ -77,6 +77,7 @@
<div class="section" id="step-1-run-the-application-reset-tool">
<h2>Step 1: Run the application reset tool<a class="headerlink" href="#step-1-run-the-application-reset-tool" title="Permalink to this headline"></a></h2>
<p>Invoke the application reset tool from the command line</p>
+ <p>Warning! This tool makes irreversible changes to your application. It is strongly recommended that you run this once with --dry-run to preview your changes before making them.</p>
Review comment:
👍 here's a screenshot for this portion:
<img width="1035" alt="Screenshot 2020-08-13 at 2 19 01 PM" src="https://user-images.githubusercontent.com/32009741/90100918-40b68300-dd70-11ea-8ae2-a08c385156da.png">
##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -167,7 +171,7 @@ public int run(final String[] args,
final HashMap<Object, Object> consumerConfig = new HashMap<>(config);
consumerConfig.putAll(properties);
exitCode = maybeResetInputAndSeekToEndIntermediateTopicOffsets(consumerConfig, dryRun);
- maybeDeleteInternalTopics(adminClient, dryRun);
+ exitCode |= maybeDeleteInternalTopics(adminClient, dryRun);
Review comment:
Yep. Currently it returns 1 if either exitCode is 1, and 0 otherwise. Or should we do something else?
##########
File path: docs/streams/developer-guide/app-reset-tool.html
##########
@@ -106,6 +107,11 @@ <h2>Step 1: Run the application reset tool<a class="headerlink" href="#step-1-ru
topics <span class="o">(</span>topics used in the through<span class="o">()</span>
method<span class="o">)</span>. For these topics, the tool
will skip to the end.
+--internal-topics <String: list> Comma-separated list of internal topics
+ to delete. Must be a subset of the
+ internal topics marked for deletion by
+ the default behaviour (do a dry-run without
+ this option to view these topics).
Review comment:
screenshot of this portion:
<img width="1031" alt="Screenshot 2020-08-13 at 2 19 35 PM" src="https://user-images.githubusercontent.com/32009741/90100950-52982600-dd70-11ea-9ae5-2b84296188cc.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org