[GitHub] [spark] sadhen commented on a change in pull request #24092: [SPARK-27160][SQL] Fix DecimalType when building orc filters

[GitBox <gi...@apache.org>]

sadhen commented on a change in pull request #24092: [SPARK-27160][SQL] Fix DecimalType when building orc filters
URL: https://github.com/apache/spark/pull/24092#discussion_r266863868
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
 ##########
 @@ -603,6 +604,27 @@ abstract class OrcQueryTest extends OrcTest {
       assert(m4.contains("Malformed ORC file"))
     }
   }
+
+  test("SPARK-27160 Predicate pushdown correctness on DecimalType for ORC") {
+    withTempPath { dir =>
+      withSQLConf(SQLConf.ORC_FILTER_PUSHDOWN_ENABLED.key -> "true") {
+        val path = dir.getCanonicalPath
+        spark.createDataFrame(
 
 Review comment:
   fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org