You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by John Casey <jd...@commonjava.org> on 2008/07/21 17:35:10 UTC
roadmap for maven-shade-plugin?
Hi everyone,
I'd like to check and see how close people think we're getting to a
release of the maven-shade-plugin. I understand there are some
outstanding issues related to excludes, but at this point the pending
1.2 release is blocking the maven 2.0.10 release.
Can we talk about specific issues that are waiting for 1.2, and who's
working on what?
Thanks,
-john
--
John Casey
Developer, PMC Member - Apache Maven (http://maven.apache.org)
Blog: http://www.ejlife.net/blogs/buildchimp/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: roadmap for maven-shade-plugin?
Posted by Paul Benedict <pb...@apache.org>.
Does anyone consider the maven-shade-plugin to be one that should get a
standard version in the super pom?
Paul
On Mon, Jul 21, 2008 at 11:53 AM, John Casey <jd...@commonjava.org> wrote:
> I'm also investigating other ways we might be able to work around the
> 2.0.10 release without requiring the new shade-plugin release, fwiw.
>
> It might be a good idea to make sure the tests are in place on this release
> of the shade plugin; I think we can put some temporary code into maven for
> 2.0.10 that will simply setup the User-Agent header in an initialize()
> method for now, then re-enable the configuration later once shade 1.2 is
> verified and released.
>
> I just want to make sure we have all of our bases covered on both sides of
> this. I don't want to rush the release of the plugin by throwing the weight
> of the maven release around, only to find that there was a subtle bug that
> would have come to light had we waited for tests. :-)
>
> -john
>
> Daniel Kulp wrote:
>
>>
>> I think it's OK to do a release of it now, especially if it's blocking
>> 2.0.10.
>>
>> I've tested it with CXF and it looks OK there. No regressions in the
>> dep-reduced pom. It would be NICE if the OpenEJB folks could do a quick
>> test with their code, but I wouldn't hold it up for that to occur.
>>
>> Dan
>>
>>
>>
>> On Jul 21, 2008, at 11:35 AM, John Casey wrote:
>>
>> Hi everyone,
>>>
>>> I'd like to check and see how close people think we're getting to a
>>> release of the maven-shade-plugin. I understand there are some outstanding
>>> issues related to excludes, but at this point the pending 1.2 release is
>>> blocking the maven 2.0.10 release.
>>>
>>> Can we talk about specific issues that are waiting for 1.2, and who's
>>> working on what?
>>>
>>> Thanks,
>>>
>>> -john
>>>
>>> --
>>> John Casey
>>> Developer, PMC Member - Apache Maven (http://maven.apache.org)
>>> Blog: http://www.ejlife.net/blogs/buildchimp/
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>> ---
>> Daniel Kulp
>> dkulp@apache.org
>> http://www.dankulp.com/blog
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
> --
> John Casey
> Developer, PMC Member - Apache Maven (http://maven.apache.org)
> Blog: http://www.ejlife.net/blogs/buildchimp/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: roadmap for maven-shade-plugin?
Posted by John Casey <jd...@commonjava.org>.
I'm also investigating other ways we might be able to work around the
2.0.10 release without requiring the new shade-plugin release, fwiw.
It might be a good idea to make sure the tests are in place on this
release of the shade plugin; I think we can put some temporary code into
maven for 2.0.10 that will simply setup the User-Agent header in an
initialize() method for now, then re-enable the configuration later once
shade 1.2 is verified and released.
I just want to make sure we have all of our bases covered on both sides
of this. I don't want to rush the release of the plugin by throwing the
weight of the maven release around, only to find that there was a subtle
bug that would have come to light had we waited for tests. :-)
-john
Daniel Kulp wrote:
>
> I think it's OK to do a release of it now, especially if it's blocking
> 2.0.10.
>
> I've tested it with CXF and it looks OK there. No regressions in the
> dep-reduced pom. It would be NICE if the OpenEJB folks could do a
> quick test with their code, but I wouldn't hold it up for that to occur.
>
> Dan
>
>
>
> On Jul 21, 2008, at 11:35 AM, John Casey wrote:
>
>> Hi everyone,
>>
>> I'd like to check and see how close people think we're getting to a
>> release of the maven-shade-plugin. I understand there are some
>> outstanding issues related to excludes, but at this point the pending
>> 1.2 release is blocking the maven 2.0.10 release.
>>
>> Can we talk about specific issues that are waiting for 1.2, and who's
>> working on what?
>>
>> Thanks,
>>
>> -john
>>
>> --
>> John Casey
>> Developer, PMC Member - Apache Maven (http://maven.apache.org)
>> Blog: http://www.ejlife.net/blogs/buildchimp/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---
> Daniel Kulp
> dkulp@apache.org
> http://www.dankulp.com/blog
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
John Casey
Developer, PMC Member - Apache Maven (http://maven.apache.org)
Blog: http://www.ejlife.net/blogs/buildchimp/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: roadmap for maven-shade-plugin?
Posted by David Blevins <da...@visi.com>.
On Jul 21, 2008, at 8:55 AM, Daniel Kulp wrote:
>
> I think it's OK to do a release of it now, especially if it's
> blocking 2.0.10.
>
> I've tested it with CXF and it looks OK there. No regressions in
> the dep-reduced pom. It would be NICE if the OpenEJB folks could
> do a quick test with their code, but I wouldn't hold it up for that
> to occur.
Tried it with some of the OpenEJB stuff and everything looked good.
-David
> On Jul 21, 2008, at 11:35 AM, John Casey wrote:
>
>> Hi everyone,
>>
>> I'd like to check and see how close people think we're getting to a
>> release of the maven-shade-plugin. I understand there are some
>> outstanding issues related to excludes, but at this point the
>> pending 1.2 release is blocking the maven 2.0.10 release.
>>
>> Can we talk about specific issues that are waiting for 1.2, and
>> who's working on what?
>>
>> Thanks,
>>
>> -john
>>
>> --
>> John Casey
>> Developer, PMC Member - Apache Maven (http://maven.apache.org)
>> Blog: http://www.ejlife.net/blogs/buildchimp/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---
> Daniel Kulp
> dkulp@apache.org
> http://www.dankulp.com/blog
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: roadmap for maven-shade-plugin?
Posted by Daniel Kulp <dk...@apache.org>.
I think it's OK to do a release of it now, especially if it's blocking
2.0.10.
I've tested it with CXF and it looks OK there. No regressions in the
dep-reduced pom. It would be NICE if the OpenEJB folks could do a
quick test with their code, but I wouldn't hold it up for that to occur.
Dan
On Jul 21, 2008, at 11:35 AM, John Casey wrote:
> Hi everyone,
>
> I'd like to check and see how close people think we're getting to a
> release of the maven-shade-plugin. I understand there are some
> outstanding issues related to excludes, but at this point the
> pending 1.2 release is blocking the maven 2.0.10 release.
>
> Can we talk about specific issues that are waiting for 1.2, and
> who's working on what?
>
> Thanks,
>
> -john
>
> --
> John Casey
> Developer, PMC Member - Apache Maven (http://maven.apache.org)
> Blog: http://www.ejlife.net/blogs/buildchimp/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: roadmap for maven-shade-plugin?
Posted by Mark Hobson <ma...@gmail.com>.
Hi John,
The thread regarding excessive excludes is here:
http://www.nabble.com/Shade-plugin%27s-over-zealous-exclusions-tt18462091.html
The latest is that Daniel made some changes which appeared to fix my
problems, although I'd like to see some unit tests for the dependency
reduced pom logic. Unfortunately there's no infrastructure there yet
for testing that part of the plugin so it's more work than I've got
time for right now.
Cheers,
Mark
2008/7/21 John Casey <jd...@commonjava.org>:
> Hi everyone,
>
> I'd like to check and see how close people think we're getting to a release
> of the maven-shade-plugin. I understand there are some outstanding issues
> related to excludes, but at this point the pending 1.2 release is blocking
> the maven 2.0.10 release.
>
> Can we talk about specific issues that are waiting for 1.2, and who's
> working on what?
>
> Thanks,
>
> -john
>
> --
> John Casey
> Developer, PMC Member - Apache Maven (http://maven.apache.org)
> Blog: http://www.ejlife.net/blogs/buildchimp/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: roadmap for maven-shade-plugin?
Posted by Daniel Kulp <dk...@apache.org>.
Method should probably be private or package protected. Thus, this
would be irrelevant.
Dan
On Jul 21, 2008, at 4:03 PM, Dennis Lundberg wrote:
> I've gone over the docs, to make sure they are OK. I also went
> through a couple of the other pre release checks.
>
> While doing this I found an error in the Clirr report that might be
> worth having a look at:
>
> In method 'public boolean
> updateExcludesInDeps(org.apache.maven.project.MavenProject,
> java.util.List)' the number of arguments has changed
>
> This is in the class org.apache.maven.plugins.shade.mojo.ShadeMojo
>
> It went from
> public boolean updateExcludesInDeps( MavenProject project,
> List dependencies )
> to
> public boolean updateExcludesInDeps( MavenProject project,
> List dependencies,
> List transitiveDeps )
>
>
> John Casey wrote:
>> Hi everyone,
>> I'd like to check and see how close people think we're getting to a
>> release of the maven-shade-plugin. I understand there are some
>> outstanding issues related to excludes, but at this point the
>> pending 1.2 release is blocking the maven 2.0.10 release.
>> Can we talk about specific issues that are waiting for 1.2, and
>> who's working on what?
>> Thanks,
>> -john
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---
Daniel Kulp
dkulp@apache.org
http://www.dankulp.com/blog
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: roadmap for maven-shade-plugin?
Posted by Dennis Lundberg <de...@apache.org>.
I've gone over the docs, to make sure they are OK. I also went through a
couple of the other pre release checks.
While doing this I found an error in the Clirr report that might be
worth having a look at:
In method 'public boolean
updateExcludesInDeps(org.apache.maven.project.MavenProject,
java.util.List)' the number of arguments has changed
This is in the class org.apache.maven.plugins.shade.mojo.ShadeMojo
It went from
public boolean updateExcludesInDeps( MavenProject project,
List dependencies )
to
public boolean updateExcludesInDeps( MavenProject project,
List dependencies,
List transitiveDeps )
John Casey wrote:
> Hi everyone,
>
> I'd like to check and see how close people think we're getting to a
> release of the maven-shade-plugin. I understand there are some
> outstanding issues related to excludes, but at this point the pending
> 1.2 release is blocking the maven 2.0.10 release.
>
> Can we talk about specific issues that are waiting for 1.2, and who's
> working on what?
>
> Thanks,
>
> -john
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org