[GitHub] [hudi] dongkelun commented on pull request #5478: [HUDI-3998] Fix getCommitsSinceLastCleaning failed when async cleaning

[GitBox <gi...@apache.org>]

dongkelun commented on PR #5478:
URL: https://github.com/apache/hudi/pull/5478#issuecomment-1126862567

   @nsivabalan  As the comments in the code,`lastCompletedCommitTimestamp`  is the last completed commit timestamp before clean. There is no guarantee that it is the last one on the whole timeline,because we can't ensure that there is no completed commit after clean,It is bound to clean.
   
    `before the last completed commit, there should not any inflight commit. either its completed or rolledback.`As for this, I think it is related to the rollback mechanism. As long as we ensure that we will rollback before each commit, this is true
    
   For version compatibility, I verified it locally, it is backward compatible .Because we added a default value for the value of `lastCompletedCommitTimestamp`  in `HoodieCleanerPlan` and  `HoodieCleanMetadata`.In this way, 'lastCompletedCommitTimestamp' uses the default value("") when serializing files of older versions.When 'lastCompletedCommitTimestamp'is an empty string,
   `numCommits = commitTimeline.findInstantsAfter(lastCompletedCommitTimestamp).countInstants();` returns the number of all completed commits,The subsequent clean operation can run normally


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org