You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/05 08:00:38 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request #7263: Refactor DCLStatement to MySQL, Oracle, PostgreSQL, SQL92 and SQLServer DCLStatement
strongduanmu opened a new pull request #7263:
URL: https://github.com/apache/shardingsphere/pull/7263
Ref #7170.
Changes proposed in this pull request:
- Refactor DCLStatement to MySQL, Oracle, PostgreSQL, SQL92 and SQLServer DCLStatement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #7263: Refactor DCLStatement to MySQL, Oracle, PostgreSQL, SQL92 and SQLServer DCLStatement
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #7263:
URL: https://github.com/apache/shardingsphere/pull/7263#discussion_r483932211
##########
File path: shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-mysql/src/test/java/org/apache/shardingsphere/proxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareCheckerTest.java
##########
@@ -81,12 +98,17 @@
@Test
public void assertIsStatementAllowed() {
List<SQLStatement> statementList = Arrays.asList(
- new AlterTableStatement(mock(SimpleTableSegment.class)), new AlterUserStatement(), new MySQLAnalyzeTableStatement(), new MySQLCacheIndexStatement(),
+ new AlterTableStatement(mock(SimpleTableSegment.class)), new MySQLAlterUserStatement(), new OracleAlterUserStatement(),
+ new PostgreSQLAlterUserStatement(), new SQLServerAlterUserStatement(), new MySQLAnalyzeTableStatement(), new MySQLCacheIndexStatement(),
new CallStatement(), new ChangeMasterStatement(), new MySQLChecksumTableStatement(), new CommitStatement(), new CreateIndexStatement(), new DropIndexStatement(),
- new CreateDatabaseStatement(""), new DropDatabaseStatement(""), new CreateTableStatement(mock(SimpleTableSegment.class)), new DropTableStatement(), new CreateUserStatement(),
- new RenameUserStatement(), new DropUserStatement(), new CreateViewStatement(), new DropViewStatement(), new DeleteStatement(), new DoStatement(), new MySQLFlushStatement(),
- new GrantStatement(), new InsertStatement(), new MySQLInstallPluginStatement(), new MySQLKillStatement(), new MySQLLoadIndexInfoStatement(), new MySQLOptimizeTableStatement(),
- new RenameTableStatement(), new MySQLRepairTableStatement(), new MySQLResetStatement(), new RevokeStatement(), new SelectStatement(), new SetStatement(), new MySQLShowWarningsStatement(),
+ new CreateDatabaseStatement(""), new DropDatabaseStatement(""), new CreateTableStatement(mock(SimpleTableSegment.class)), new DropTableStatement(),
Review comment:
I suppose other `database` SQL Statements except for `MySQL` are not wanted here. See the name of this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7263: Refactor DCLStatement to MySQL, Oracle, PostgreSQL, SQL92 and SQLServer DCLStatement
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7263:
URL: https://github.com/apache/shardingsphere/pull/7263#issuecomment-687574208
## Pull Request Test Coverage Report for [Build 14456](https://coveralls.io/builds/33255461)
* **40** of **99** **(40.4%)** changed or added relevant lines in **63** files are covered.
* **10** unchanged lines in **5** files lost coverage.
* Overall coverage decreased (**-0.01%**) to **34.117%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/AlterLoginStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FAlterLoginStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/AlterRoleStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FAlterRoleStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/AlterUserStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FAlterUserStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/CreateLoginStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FCreateLoginStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/CreateRoleStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FCreateRoleStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/CreateUserStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FCreateUserStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/DenyUserStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FDenyUserStatement.java#L30) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/DropLoginStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FDropLoginStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/DropRoleStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FDropRoleStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/DropUserStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FDropUserStatement.java#L25) | 0 | 1 | 0.0%
<!-- | **Total:** | **40** | **99** | **40.4%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/GrantStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FGrantStatement.java#L33) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/RevokeStatement.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FRevokeStatement.java#L33) | 1 | 0% |
| [shardingsphere-jdbc/shardingsphere-jdbc-governance/src/main/java/org/apache/shardingsphere/driver/governance/internal/datasource/GovernanceShardingSphereDataSource.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-governance%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fgovernance%2Finternal%2Fdatasource%2FGovernanceShardingSphereDataSource.java#L137) | 2 | 96.43% |
| [shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/datasource/DataSourceConfiguration.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-infra%2Fshardingsphere-infra-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fconfig%2Fdatasource%2FDataSourceConfiguration.java#L146) | 3 | 91.67% |
| [shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/datasource/ShardingSphereDataSource.java](https://coveralls.io/builds/33255461/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fjdbc%2Fcore%2Fdatasource%2FShardingSphereDataSource.java#L48) | 3 | 91.67% |
<!-- | **Total:** | **10** | | -->
| Totals | [](https://coveralls.io/builds/33255461) |
| :-- | --: |
| Change from base [Build 14440](https://coveralls.io/builds/33252881): | -0.01% |
| Covered Lines: | 35432 |
| Relevant Lines: | 103855 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on pull request #7263: Refactor DCLStatement to MySQL, Oracle, PostgreSQL, SQL92 and SQLServer DCLStatement
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on pull request #7263:
URL: https://github.com/apache/shardingsphere/pull/7263#issuecomment-687778318
> > Since this change is big, please perform the integration test using MySQL.
> > 1, env.properties:
> > databases=MySQL
> > mysql.host=127.0.0.1 (suppose your MySQL is on localhost)
> > 2, go to shardingsphere-test-suite module
> > 3, mvn clean install
>
> @tuohai666 I have used the PR branch(`strongduanmu:issue-7170-dev-0904`) and the master branch to execute `mvn clean install` in the `shardingsphere-test-suite` module, and found that both branches have a lot of exceptions.
> How can I test the impact of this PR? 🤔
Hi, you can just run BaseDCLIT instead of mvn install.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7263: Refactor DCLStatement to MySQL, Oracle, PostgreSQL, SQL92 and SQLServer DCLStatement
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7263:
URL: https://github.com/apache/shardingsphere/pull/7263#issuecomment-687574208
## Pull Request Test Coverage Report for [Build 14442](https://coveralls.io/builds/33253329)
* **40** of **99** **(40.4%)** changed or added relevant lines in **63** files are covered.
* **2** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.01%**) to **34.114%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/AlterLoginStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FAlterLoginStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/AlterRoleStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FAlterRoleStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/AlterUserStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FAlterUserStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/CreateLoginStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FCreateLoginStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/CreateRoleStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FCreateRoleStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/CreateUserStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FCreateUserStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/DenyUserStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FDenyUserStatement.java#L30) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/DropLoginStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FDropLoginStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/DropRoleStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FDropRoleStatement.java#L25) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/DropUserStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FDropUserStatement.java#L25) | 0 | 1 | 0.0%
<!-- | **Total:** | **40** | **99** | **40.4%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/GrantStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FGrantStatement.java#L33) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dcl/RevokeStatement.java](https://coveralls.io/builds/33253329/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdcl%2FRevokeStatement.java#L33) | 1 | 0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/33253329) |
| :-- | --: |
| Change from base [Build 14440](https://coveralls.io/builds/33252881): | -0.01% |
| Covered Lines: | 35434 |
| Relevant Lines: | 103868 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #7263: Refactor DCLStatement to MySQL, Oracle, PostgreSQL, SQL92 and SQLServer DCLStatement
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7263:
URL: https://github.com/apache/shardingsphere/pull/7263
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #7263: Refactor DCLStatement to MySQL, Oracle, PostgreSQL, SQL92 and SQLServer DCLStatement
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #7263:
URL: https://github.com/apache/shardingsphere/pull/7263#issuecomment-687774747
> Since this change is big, please perform the integration test using MySQL.
>
> 1, env.properties:
> databases=MySQL
> mysql.host=127.0.0.1 (suppose your MySQL is on localhost)
>
> 2, go to shardingsphere-test-suite module
>
> 3, mvn clean install
@tuohai666 I have used the PR branch(`strongduanmu:issue-7170-dev-0904`) and the master branch to execute `mvn clean install` in the `shardingsphere-test-suite` module, and found that both branches have a lot of exceptions.
How can I test the impact of this PR? 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #7263: Refactor DCLStatement to MySQL, Oracle, PostgreSQL, SQL92 and SQLServer DCLStatement
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #7263:
URL: https://github.com/apache/shardingsphere/pull/7263#issuecomment-687791285
> > > Since this change is big, please perform the integration test using MySQL.
> > > 1, env.properties:
> > > databases=MySQL
> > > mysql.host=127.0.0.1 (suppose your MySQL is on localhost)
> > > 2, go to shardingsphere-test-suite module
> > > 3, mvn clean install
> >
> >
> > @tuohai666 I have used the PR branch(`strongduanmu:issue-7170-dev-0904`) and the master branch to execute `mvn clean install` in the `shardingsphere-test-suite` module, and found that both branches have a lot of exceptions.
> > How can I test the impact of this PR? 🤔
>
> Hi, you can just run BaseDCLIT instead of mvn install.
@tuohai666 Thank you so much for your help. I have run `BaseDCLIT` on the pr branch and all the test cases have passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #7263: Refactor DCLStatement to MySQL, Oracle, PostgreSQL, SQL92 and SQLServer DCLStatement
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #7263:
URL: https://github.com/apache/shardingsphere/pull/7263#discussion_r483951830
##########
File path: shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-mysql/src/test/java/org/apache/shardingsphere/proxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareCheckerTest.java
##########
@@ -81,12 +98,17 @@
@Test
public void assertIsStatementAllowed() {
List<SQLStatement> statementList = Arrays.asList(
- new AlterTableStatement(mock(SimpleTableSegment.class)), new AlterUserStatement(), new MySQLAnalyzeTableStatement(), new MySQLCacheIndexStatement(),
+ new AlterTableStatement(mock(SimpleTableSegment.class)), new MySQLAlterUserStatement(), new OracleAlterUserStatement(),
+ new PostgreSQLAlterUserStatement(), new SQLServerAlterUserStatement(), new MySQLAnalyzeTableStatement(), new MySQLCacheIndexStatement(),
new CallStatement(), new ChangeMasterStatement(), new MySQLChecksumTableStatement(), new CommitStatement(), new CreateIndexStatement(), new DropIndexStatement(),
- new CreateDatabaseStatement(""), new DropDatabaseStatement(""), new CreateTableStatement(mock(SimpleTableSegment.class)), new DropTableStatement(), new CreateUserStatement(),
- new RenameUserStatement(), new DropUserStatement(), new CreateViewStatement(), new DropViewStatement(), new DeleteStatement(), new DoStatement(), new MySQLFlushStatement(),
- new GrantStatement(), new InsertStatement(), new MySQLInstallPluginStatement(), new MySQLKillStatement(), new MySQLLoadIndexInfoStatement(), new MySQLOptimizeTableStatement(),
- new RenameTableStatement(), new MySQLRepairTableStatement(), new MySQLResetStatement(), new RevokeStatement(), new SelectStatement(), new SetStatement(), new MySQLShowWarningsStatement(),
+ new CreateDatabaseStatement(""), new DropDatabaseStatement(""), new CreateTableStatement(mock(SimpleTableSegment.class)), new DropTableStatement(),
Review comment:
> I suppose other `database` SQL Statements except for `MySQL` are not wanted here. See the name of this class.
@tristaZero I am very sorry for this mistake, and I will check this logic again. 🤣
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org