You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/04 22:28:38 UTC

[GitHub] [hudi] yihua commented on a diff in pull request #6028: [HUDI-4355] Bulk insert As Row: Should also repartiiton records if populateMetaFields is false

yihua commented on code in PR #6028:
URL: https://github.com/apache/hudi/pull/6028#discussion_r913283653


##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/HoodieDatasetBulkInsertHelper.java:
##########
@@ -182,8 +184,8 @@ public static Dataset<Row> prepareHoodieDatasetForBulkInsertWithoutMetaFields(Da
     allCols.addAll(metaFields);
     allCols.addAll(originalFields);
 
-    return rowsWithMetaCols.select(
-        JavaConverters.collectionAsScalaIterableConverter(allCols).asScala().toSeq());
+    return bulkInsertPartitionerRows.repartitionRecords(rowsWithMetaCols.select(

Review Comment:
   `NonSortPartitionerWithRows` does `coalesce` for the input rows inside `repartitionRecords()`.  Is that the intended behavior here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org