[GitHub] [ozone] krishnaasawa1 commented on a diff in pull request #4537: HDDS-8352. OM crashed due to OzoneAclUtils.isOwner() throwing NPE

["krishnaasawa1 (via GitHub)" <gi...@apache.org>]

krishnaasawa1 commented on code in PR #4537:
URL: https://github.com/apache/ozone/pull/4537#discussion_r1163887937


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java:
##########
@@ -81,7 +81,8 @@ public OMKeyCommitRequest(OMRequest omRequest, BucketLayout bucketLayout) {
 
   @Override
   public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
-    CommitKeyRequest commitKeyRequest = getOmRequest().getCommitKeyRequest();

Review Comment:
   Changes looks straightforward   preExecute to invoke  -> preExecute of OMClientRequest to populate Userinfo and remove explicitly populating below via builder which was causing the issue.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org