You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/05/29 12:37:33 UTC

[GitHub] [hudi] codope commented on pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

codope commented on pull request #2915:
URL: https://github.com/apache/hudi/pull/2915#issuecomment-850826058


   > @codope : all feedback addressed? can we review. or do ping us here once its ready for review.
   
   @nsivabalan Almost all comments are addressed. One remaining is regarding the validations of incremental column. I had a question there https://github.com/apache/hudi/pull/2915#discussion_r633690635
   
   Could you please suggest how to proceed on that? As per current implementation, in case of non-existent column or mismatching column type, an exception will be thrown and puller will stop.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org