[jira] [Updated] (BEAM-4704) String operations yield incorrect results when executed through SQL shell

["Andrew Pilloud (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Pilloud updated BEAM-4704:
---------------------------------
    Fix Version/s: 2.8.0
         Assignee: Andrew Pilloud
       Resolution: Fixed
           Status: Resolved  (was: Open)

Should be resolved by https://github.com/apache/beam/pull/6389

> String operations yield incorrect results when executed through SQL shell
> -------------------------------------------------------------------------
>
>                 Key: BEAM-4704
>                 URL: https://issues.apache.org/jira/browse/BEAM-4704
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: Kenneth Knowles
>            Assignee: Andrew Pilloud
>            Priority: P3
>             Fix For: 2.8.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> {{TRIM}} is defined to trim _all_ the characters in the first string from the string-to-be-trimmed. Calcite has an incorrect implementation of this. We use our own fixed implementation. But when executed through the SQL shell, the results do not match what we get from the PTransform path. Here two test cases that pass on {{master}} but are incorrect in the shell:
> {code:sql}
> BeamSQL> select TRIM(LEADING 'eh' FROM 'hehe__hehe');
> +------------+
> | EXPR$0 |
> +------------+
> | hehe__hehe |
> +------------+
> {code}
> {code:sql}
> BeamSQL> select TRIM(TRAILING 'eh' FROM 'hehe__hehe');
> +------------+
> |   EXPR$0   |
> +------------+
> | hehe__heh  |
> +------------+
> {code}
> {code:sql}
> BeamSQL> select TRIM(BOTH 'eh' FROM 'hehe__hehe');
> +------------+
> |   EXPR$0   |
> +------------+
> | hehe__heh  |
> +------------+
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)