You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Tomasz Reg (Jira)" <ji...@apache.org> on 2023/11/19 12:34:00 UTC

[jira] [Comment Edited] (MJAR-296) No way to suppress default excludes in maven-jar-plugin

    [ https://issues.apache.org/jira/browse/MJAR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787594#comment-17787594 ] 

Tomasz Reg edited comment on MJAR-296 at 11/19/23 12:33 PM:
------------------------------------------------------------

I took the liberty of proposing an implementation for such a feature.
[~michael-o] please take a look when available: [https://github.com/apache/maven-jar-plugin/pull/67].


was (Author: JIRAUSER303129):
I took the liberty of creating a proposal for such a feature.
[~michael-o] please take a look when available: https://github.com/apache/maven-jar-plugin/pull/67.

> No way to suppress default excludes in maven-jar-plugin
> -------------------------------------------------------
>
>                 Key: MJAR-296
>                 URL: https://issues.apache.org/jira/browse/MJAR-296
>             Project: Maven JAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.3.0
>            Reporter: G.Vaysman
>            Priority: Major
>         Attachments: jar-default-excludes.zip
>
>
> With the default excludes being expanded further (see org.codehaus.plexus.util.AbstractScanner.{*}_DEFAULTEXCLUDES_{*}), a resource directory **/ChangeSet/** will never be included in the JAR artifact.
> Some plugins (maven-resources-plugin, maven-assembly-plugin) already allow suppressing the exclusion, but not the maven-jar-plugin. Code analysis of the JarMojo -> DirectoryScanner call path confirms that there is no way to affect the FileSet configuration. 
> Again, with ever expanding list of *_DEFAULTEXCLUDES,_* this, on our opinion, is quite detrimental, and due to backward compatibility, changing resource/package path (say, to ChangeSet2) is not an option. 
> I am attaching a very simple project that shows two things:
>  # The jar plugin skips adding the **/ChangeSet/** files
>  # The resources plugin is configured not to skip (addDefaultExcludes) and behaves properly



--
This message was sent by Atlassian Jira
(v8.20.10#820010)