You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2021/10/22 18:09:26 UTC
svn commit: r1894490 - in /poi/trunk:
poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/
Author: fanningpj
Date: Fri Oct 22 18:09:26 2021
New Revision: 1894490
URL: http://svn.apache.org/viewvc?rev=1894490&view=rev
Log:
remove finalizer
Modified:
poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/DeferredGeneration.java
poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/Outlining.java
poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/SavePasswordProtectedXlsx.java
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
Modified: poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/DeferredGeneration.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/DeferredGeneration.java?rev=1894490&r1=1894489&r2=1894490&view=diff
==============================================================================
--- poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/DeferredGeneration.java (original)
+++ poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/DeferredGeneration.java Fri Oct 22 18:09:26 2021
@@ -56,6 +56,7 @@ public class DeferredGeneration {
//writeAvoidingTempFiles was added as an experimental change in POI 5.1.0
//wb.writeAvoidingTempFiles(fileOut);
} finally {
+ //the dispose call is necessary to ensure temp files are removed
wb.dispose();
}
System.out.println("wrote DeferredGeneration.xlsx");
Modified: poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/Outlining.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/Outlining.java?rev=1894490&r1=1894489&r2=1894490&view=diff
==============================================================================
--- poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/Outlining.java (original)
+++ poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/Outlining.java Fri Oct 22 18:09:26 2021
@@ -47,6 +47,7 @@ public class Outlining {
try (FileOutputStream fileOut = new FileOutputStream("outlining_collapsed.xlsx")) {
wb2.write(fileOut);
} finally {
+ //the dispose call is necessary to ensure temp files are removed
wb2.dispose();
}
}
Modified: poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/SavePasswordProtectedXlsx.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/SavePasswordProtectedXlsx.java?rev=1894490&r1=1894489&r2=1894490&view=diff
==============================================================================
--- poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/SavePasswordProtectedXlsx.java (original)
+++ poi/trunk/poi-examples/src/main/java/org/apache/poi/examples/xssf/streaming/SavePasswordProtectedXlsx.java Fri Oct 22 18:09:26 2021
@@ -80,6 +80,7 @@ public final class SavePasswordProtected
}
} finally {
wb.close();
+ //the dispose call is necessary to ensure temp files are removed
wb.dispose();
}
TempFileUtils.checkTempFiles();
Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java?rev=1894490&r1=1894489&r2=1894490&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java Fri Oct 22 18:09:26 2021
@@ -152,6 +152,9 @@ public class SheetDataWriter implements
*/
public InputStream getWorksheetXMLInputStream() throws IOException {
File fd = getTempFile();
+ if (fd == null) {
+ throw new IOException("getWorksheetXMLInputStream only works when a temp file is used");
+ }
FileInputStream fis = new FileInputStream(fd);
try {
return decorateInputStream(fis);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org