You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bval.apache.org by "Carlos Vara (JIRA)" <ji...@apache.org> on 2010/05/04 15:04:55 UTC
[jira] Created: (BVAL-35) Improved support of @OverridesAttribute
Improved support of @OverridesAttribute
---------------------------------------
Key: BVAL-35
URL: https://issues.apache.org/jira/browse/BVAL-35
Project: BeanValidation
Issue Type: Bug
Components: jsr303
Affects Versions: 0.1-incubating
Reporter: Carlos Vara
Attachments: bval-jsr303-35.patch
Several changes to the current implementation:
- Changed index calculation, indexes are always >= 0.
- When applying overrides, not only the attributes are updated, but also the annotation.
- Deferred validator initialization until all the override information is gathered. To comply with this, it has been moved to a post-processing phase in AppendValidation.
- Added an abstract base AppendValidation implementation to implement the point above.
- Restore constraint validation context after validating compositing constraints.
3 more tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BVAL-35) Improved support of @OverridesAttribute
Posted by "Roman Stumm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Stumm reassigned BVAL-35:
-------------------------------
Assignee: Roman Stumm
> Improved support of @OverridesAttribute
> ---------------------------------------
>
> Key: BVAL-35
> URL: https://issues.apache.org/jira/browse/BVAL-35
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.1-incubating
> Reporter: Carlos Vara
> Assignee: Roman Stumm
> Attachments: bval-jsr303-35.patch
>
>
> Several changes to the current implementation:
> - Changed index calculation, indexes are always >= 0.
> - When applying overrides, not only the attributes are updated, but also the annotation.
> - Deferred validator initialization until all the override information is gathered. To comply with this, it has been moved to a post-processing phase in AppendValidation.
> - Added an abstract base AppendValidation implementation to implement the point above.
> - Restore constraint validation context after validating compositing constraints.
> 3 more tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BVAL-35) Improved support of @OverridesAttribute
Posted by "Carlos Vara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Vara updated BVAL-35:
----------------------------
Attachment: bval-jsr303-35.patch
Patch and extra test.
> Improved support of @OverridesAttribute
> ---------------------------------------
>
> Key: BVAL-35
> URL: https://issues.apache.org/jira/browse/BVAL-35
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.1-incubating
> Reporter: Carlos Vara
> Attachments: bval-jsr303-35.patch
>
>
> Several changes to the current implementation:
> - Changed index calculation, indexes are always >= 0.
> - When applying overrides, not only the attributes are updated, but also the annotation.
> - Deferred validator initialization until all the override information is gathered. To comply with this, it has been moved to a post-processing phase in AppendValidation.
> - Added an abstract base AppendValidation implementation to implement the point above.
> - Restore constraint validation context after validating compositing constraints.
> 3 more tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BVAL-35) Improved support of @OverridesAttribute
Posted by "Roman Stumm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Stumm resolved BVAL-35.
-----------------------------
Fix Version/s: 0.1-incubating
Resolution: Fixed
thanks, very nice!
> Improved support of @OverridesAttribute
> ---------------------------------------
>
> Key: BVAL-35
> URL: https://issues.apache.org/jira/browse/BVAL-35
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.1-incubating
> Reporter: Carlos Vara
> Assignee: Roman Stumm
> Fix For: 0.1-incubating
>
> Attachments: bval-jsr303-35.patch
>
>
> Several changes to the current implementation:
> - Changed index calculation, indexes are always >= 0.
> - When applying overrides, not only the attributes are updated, but also the annotation.
> - Deferred validator initialization until all the override information is gathered. To comply with this, it has been moved to a post-processing phase in AppendValidation.
> - Added an abstract base AppendValidation implementation to implement the point above.
> - Restore constraint validation context after validating compositing constraints.
> 3 more tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BVAL-35) Improved support of @OverridesAttribute
Posted by "Carlos Vara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863834#action_12863834 ]
Carlos Vara commented on BVAL-35:
---------------------------------
I have another small fix ready that builds on the last point (restoring the context) that makes 7 more tests to pass.
Not hurrying you guys at all, just anticipating :-)
> Improved support of @OverridesAttribute
> ---------------------------------------
>
> Key: BVAL-35
> URL: https://issues.apache.org/jira/browse/BVAL-35
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.1-incubating
> Reporter: Carlos Vara
> Attachments: bval-jsr303-35.patch
>
>
> Several changes to the current implementation:
> - Changed index calculation, indexes are always >= 0.
> - When applying overrides, not only the attributes are updated, but also the annotation.
> - Deferred validator initialization until all the override information is gathered. To comply with this, it has been moved to a post-processing phase in AppendValidation.
> - Added an abstract base AppendValidation implementation to implement the point above.
> - Restore constraint validation context after validating compositing constraints.
> 3 more tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.