You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@airavata.apache.org by GitBox <gi...@apache.org> on 2020/04/30 23:51:02 UTC
[GitHub] [airavata-mft] gkiran292 opened a new pull request #15: Bugfix/mft transports
gkiran292 opened a new pull request #15:
URL: https://github.com/apache/airavata-mft/pull/15
There were streams that were not closed and redundant use of outputstream.flush()
outputstream.close() does flush internally!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-mft] aarushiibisht commented on a change in pull request #15: Bugfix/mft transports
Posted by GitBox <gi...@apache.org>.
aarushiibisht commented on a change in pull request #15:
URL: https://github.com/apache/airavata-mft/pull/15#discussion_r418398914
##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/file/FileBasedResourceBackend.java
##########
@@ -383,4 +385,75 @@ public boolean updateDropboxResource(DropboxResourceUpdateRequest request) throw
public boolean deleteDropboxResource(DropboxResourceDeleteRequest request) throws Exception {
throw new UnsupportedOperationException("Operation is not supported in backend");
}
+
+ @Override
+ public Optional<FTPResource> getFTPResource(FTPResourceGetRequest request) throws Exception {
+ InputStream inputStream = FileBasedResourceBackend.class.getClassLoader().getResourceAsStream("resources.json");
Review comment:
Minor Suggestion: instead of hard coding the name of resource file use field resourceFile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-mft] gkiran292 commented on a change in pull request #15: Bugfix/mft transports
Posted by GitBox <gi...@apache.org>.
gkiran292 commented on a change in pull request #15:
URL: https://github.com/apache/airavata-mft/pull/15#discussion_r418701390
##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/file/FileBasedResourceBackend.java
##########
@@ -383,4 +385,75 @@ public boolean updateDropboxResource(DropboxResourceUpdateRequest request) throw
public boolean deleteDropboxResource(DropboxResourceDeleteRequest request) throws Exception {
throw new UnsupportedOperationException("Operation is not supported in backend");
}
+
+ @Override
+ public Optional<FTPResource> getFTPResource(FTPResourceGetRequest request) throws Exception {
+ InputStream inputStream = FileBasedResourceBackend.class.getClassLoader().getResourceAsStream("resources.json");
Review comment:
Done I have changed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-mft] gkiran292 commented on pull request #15: Bugfix/mft transports
Posted by GitBox <gi...@apache.org>.
gkiran292 commented on pull request #15:
URL: https://github.com/apache/airavata-mft/pull/15#issuecomment-622533013
> I can see FTP changes also in the PR
Yes, Dimuthu. I checked out a branch from the feature/FTP-transport. That is why you are able to see those FTP changes too. I will close this PR and raise the PR after FTP is merged. But my question is whether the PR would still show the FTP related file changes after the FTP changes are merged to master. I am sure I need to pull from the feature/FTP-transport again as I have made changes to cater to the FTP-transport PR reviews. If it shows FTP related files even after the PR (https://github.com/apache/airavata-mft/pull/13) is merged, I will close this PR and raise another.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-mft] gkiran292 commented on a change in pull request #15: Bugfix/mft transports
Posted by GitBox <gi...@apache.org>.
gkiran292 commented on a change in pull request #15:
URL: https://github.com/apache/airavata-mft/pull/15#discussion_r418704581
##########
File path: services/resource-service/server/src/main/java/org/apache/airavata/mft/resource/server/backend/file/FileBasedResourceBackend.java
##########
@@ -383,4 +385,75 @@ public boolean updateDropboxResource(DropboxResourceUpdateRequest request) throw
public boolean deleteDropboxResource(DropboxResourceDeleteRequest request) throws Exception {
throw new UnsupportedOperationException("Operation is not supported in backend");
}
+
+ @Override
+ public Optional<FTPResource> getFTPResource(FTPResourceGetRequest request) throws Exception {
+ InputStream inputStream = FileBasedResourceBackend.class.getClassLoader().getResourceAsStream("resources.json");
Review comment:
Since this branch is taken out of feature/ftp-transport. I have made the changes there as it is related to that I am attaching my commit here
https://github.com/apache/airavata-mft/pull/13/commits/68897a10d99e776aaa2dd8bccce13287fb3e7783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org