You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "mcarlett (via GitHub)" <gi...@apache.org> on 2023/08/14 09:29:09 UTC
[GitHub] [camel] mcarlett opened a new pull request, #11101: CAMEL-19737: Updates aws2-sns queueUrl to queueArn
mcarlett opened a new pull request, #11101:
URL: https://github.com/apache/camel/pull/11101
# Description
Since AWS SNS [subscription needs endpoint in ARN format](https://docs.aws.amazon.com/sns/latest/dg/sns-create-subscribe-endpoint-to-topic.html#sns-endpoints) I changed the `queueUrl` parameter to `queueArn` parameter
# Target
- [x ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [ x] I checked that each commit in the pull request has a meaningful subject line and body.
- [x ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mcarlett commented on pull request #11101: CAMEL-19737: Updates aws2-sns queueUrl to queueArn
Posted by "mcarlett (via GitHub)" <gi...@apache.org>.
mcarlett commented on PR #11101:
URL: https://github.com/apache/camel/pull/11101#issuecomment-1677066224
> Please add this change to migration guide
@oscerd since the Jira issue has been updated to fix this on next minor/patch release I updated the upgrade guide, is it correct or do I move this in migration guide? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11101: CAMEL-19737: Updates aws2-sns queueUrl to queueArn
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11101:
URL: https://github.com/apache/camel/pull/11101#issuecomment-1677093781
It's fine. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11101: CAMEL-19737: Updates aws2-sns queueUrl to queueArn
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11101:
URL: https://github.com/apache/camel/pull/11101#issuecomment-1676994018
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #11101: CAMEL-19737: Updates aws2-sns queueUrl to queueArn
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #11101:
URL: https://github.com/apache/camel/pull/11101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org