You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2013/09/27 02:13:03 UTC

[jira] [Commented] (OAK-1050) Remove Blob.sha256()

    [ https://issues.apache.org/jira/browse/OAK-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779477#comment-13779477 ] 

Jukka Zitting commented on OAK-1050:
------------------------------------

As a followup, in revision 1526757 I adjusted the definition of equals() and hashCode() for Blobs to make them easier and more efficient to implement across different backends.
                
> Remove Blob.sha256()
> --------------------
>
>                 Key: OAK-1050
>                 URL: https://issues.apache.org/jira/browse/OAK-1050
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>
> The {{Blob.sha256()}} method can be really expensive as the MicroKernel doesn't keep track of that information and thus the method may result in a full scan of potentially gigabytes of data. Furthermore the method is only used for internal purposes.
> Thus I suggest that we remove the method from the public Blob interface and keep the functionality only as an implementation detail for now. We can always bring back the method or something similar when there is real need for it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira