You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/01 00:38:41 UTC
[GitHub] [arrow-rs] askoa commented on a diff in pull request #3411: refactor: `*like_dyn` refactor
askoa commented on code in PR #3411:
URL: https://github.com/apache/arrow-rs/pull/3411#discussion_r1059691854
##########
arrow-string/src/like.rs:
##########
@@ -25,6 +25,53 @@ use arrow_select::take::take;
use regex::Regex;
use std::collections::HashMap;
+macro_rules! dyn_function {
+ ($sql:tt, $fn_name:tt, $fn_utf8:tt, $fn_dict:tt) => {
+#[doc = concat!("Perform SQL `left ", $sql ," right` operation on [`StringArray`] /")]
+/// [`LargeStringArray`], or [`DictionaryArray`] with values
+/// [`StringArray`]/[`LargeStringArray`].
+///
+/// See the documentation on [`like_utf8`] for more details.
Review Comment:
The `*like_utf8` name is already captured in the macro. So I just added a document line. I just don't see the benefits of comment outside the macro vs inside it. So I left the comments inside the macro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org