[GitHub] [spark] seayoun commented on pull request #31643: [SPARK-34534] Fix blockIds order when use FetchShuffleBlocks to fetch blocks

[GitBox <gi...@apache.org>]

seayoun commented on pull request #31643:
URL: https://github.com/apache/spark/pull/31643#issuecomment-786391637


   > @seayoun Can this be fixed by using a LinkedHashMap for `mapIdToReduceIds` in `createFetchShuffleBlocksMsg`?
   > https://github.com/apache/spark/blob/f7ac2d655c756100c33e652402cefc507d2493b7/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java#L119
   > 
   > LinkedHashMap will return the keys in insertion order and the values are already ordered.
   > Or is the problem something different?
   
   Yes, and we shoud add an assert when blockIds parsed, so I use a arrayList to build mapIds and to check mapId order in blockIds. cc @cloud-fan 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org