[jira] [Commented] (KUDU-1438) [java client] Upgrade to Netty 4

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KUDU-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032752#comment-17032752 ] 

ASF subversion and git services commented on KUDU-1438:
-------------------------------------------------------

Commit 57dda5d4868d29f68de4aa0ac516ca390333e6be in kudu's branch refs/heads/master from Grant Henke
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=57dda5d ]

KUDU-1438: [java] Upgrade to Netty 4

This patch upgrades from Netty 3 to the latest Netty 4.
Below is a list of some of the changes required:
- Changed org.jboss.netty imports to io.netty
- Adjust shading to relocate io.netty
- Removed outdated reflection in Bytes.java
- Changed ChannelBuffer to ByteBuffer
- Changed OneToOneDecoder to BytesToMessageDecoder
- Changed OneToOneEncoder to MessageToByteEncoder
- Changed DecoderEmbedder to EmbeddedChannel
- Changed Negotiator and Connection to extend
  SimpleChannelInboundHandler instead of
  SimpleChannelUpstreamHandler
- Worked around non-sharable SslHandler
- Migrated from NioClientSocketChannelFactory to Netty Boostrap
- Removed boss threads and deprecated setter methods in the
  AsyncKuduClient
- Removed ShutdownThread in AsyncKuduClient
- Updated Negotiator tests to unwrap SSL messages
- Added build flag to run tests with paranoid level leak detection
- Suppressed errorprone FutureReturnValueIgnored warnings

I used YCSB to performance test this change and ensure there
isn’t a large performance regression. On an m4.2xlarge instance
I ran a test of 5 iterations of workload a, b, and c using 1M records
and 1M operations. The difference between runs was negligible
(< 1%) and within test variance.

Change-Id: Ic75bd15a982187039ff2e1510af9390d304f7626
Reviewed-on: http://gerrit.cloudera.org:8080/15136
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>


> [java client] Upgrade to Netty 4
> --------------------------------
>
>                 Key: KUDU-1438
>                 URL: https://issues.apache.org/jira/browse/KUDU-1438
>             Project: Kudu
>          Issue Type: Improvement
>          Components: client
>            Reporter: Jean-Daniel Cryans
>            Assignee: Grant Henke
>            Priority: Major
>              Labels: roadmap-candidate
>
> Netty 4 promises better performance for certain workloads, it was an effort mostly led by Twitter. See their blog post about it: https://blog.twitter.com/2013/netty-4-at-twitter-reduced-gc-overhead
> asynchbase has a pull request for this, so our work should be similar: https://github.com/OpenTSDB/asynchbase/pull/116/commits



--
This message was sent by Atlassian Jira
(v8.3.4#803005)