You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pdxcodemonkey (GitHub)" <gi...@apache.org> on 2018/10/25 22:07:26 UTC
[GitHub] [geode-native] pdxcodemonkey opened pull request #384:
GEODE-5251: parameterize assembly info
[ Full content available at: https://github.com/apache/geode-native/pull/384 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #384:
GEODE-5251: parameterize assembly info
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
We don't specifically need this in CMakeLists.txt, but per the above we need PRODUCT_BASE_NAME in the assembly info, so may as well use it if we have it.
[ Full content available at: https://github.com/apache/geode-native/pull/384 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #384:
GEODE-5251: parameterize assembly info
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
Okay looks like copyright string can remain the same. @echobravopapa PRODUCT_BASE_NAME was broken out so that we could use the string "Apache" or "Gemfire" in the assembly info by itself.
[ Full content available at: https://github.com/apache/geode-native/pull/384 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #384:
GEODE-5251: parameterize assembly info
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
Waiting for a response to a question about Copyright string etc. then I'll update...
[ Full content available at: https://github.com/apache/geode-native/pull/384 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] echobravopapa commented on pull request #384:
GEODE-5251: parameterize assembly info
Posted by "echobravopapa (GitHub)" <gi...@apache.org>.
Looks like this was done to be able to string build vendor.basename...
[ Full content available at: https://github.com/apache/geode-native/pull/384 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] echobravopapa commented on pull request #384:
GEODE-5251: parameterize assembly info
Posted by "echobravopapa (GitHub)" <gi...@apache.org>.
Not sure we need this... given the line above was not changed..
[ Full content available at: https://github.com/apache/geode-native/pull/384 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey closed pull request #384:
GEODE-5251: parameterize assembly info
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
[ pull request closed by pdxcodemonkey ]
[ Full content available at: https://github.com/apache/geode-native/pull/384 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #384:
GEODE-5251: parameterize assembly info
Posted by "mmartell (GitHub)" <gi...@apache.org>.
@pdxcodemonkey do you have any updates?
[ Full content available at: https://github.com/apache/geode-native/pull/384 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org