You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/04 22:22:44 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #27381: Additional info about Segmentation Violation in LocalTaskJob

potiuk commented on code in PR #27381:
URL: https://github.com/apache/airflow/pull/27381#discussion_r1039039816


##########
airflow/jobs/local_task_job.py:
##########
@@ -83,6 +113,14 @@ def signal_handler(signum, frame):
             self.task_runner.terminate()
             self.handle_task_exit(128 + signum)
 
+        def segfault_signal_handler(signum, frame):
+            """Setting sigmentation violation signal handler"""
+            self.log.critical(SIGSEGV_MESSAGE)
+            self.task_runner.terminate()
+            self.handle_task_exit(128 + signum)
+            raise AirflowException("Segmentation Fault detected.")
+
+        signal.signal(signal.SIGSEGV, segfault_signal_handler)

Review Comment:
   Agree with @uranusjr . Let's merge and see. When you have SIGSEGV you are screwed anyway, we cannot get it any worse.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org