Re: Review Request 27670: Bug fix: Check for non-zero status code and hadoop client not found

[Ankur Chauhan <an...@malloc64.com>]

> On Nov. 8, 2014, 8:14 a.m., Mesos ReviewBot wrote:
> > Patch looks great!
> > 
> > Reviews applied: [27670]
> > 
> > All tests passed.
> 
> Ankur Chauhan wrote:
>     Bump: Is there any more review suggestion that need to be incorporated to get this patch in?
> 
> Vinod Kone wrote:
>     i was waiting for @benh to ship.

I don't know if there is a feature to 'ping' benh. Maybe this just got lost in the flurry of emails.


- Ankur


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27670/#review60481
-----------------------------------------------------------


On Nov. 8, 2014, 7:28 a.m., Ankur Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27670/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2014, 7:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1711
>     https://issues.apache.org/jira/browse/MESOS-1711
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> @benh noticed that the fetcher would detect the condition where hadoop returns a success in case of a success non zero value
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 400fadf94d35721cabaa9983b12a5d35f71f5b5b 
> 
> Diff: https://reviews.apache.org/r/27670/diff/
> 
> 
> Testing
> -------
> 
> make check
> sudo bin/mesos-tests.sh --verbose
> support/mesos-style.py
> 
> 
> Thanks,
> 
> Ankur Chauhan
> 
>