[GitHub] [incubator-pinot] siddharthteotia commented on issue #5115: Refactor the data source to include all information needed for query execution

[GitBox <gi...@apache.org>]

siddharthteotia commented on issue #5115: Refactor the data source to include all information needed for query execution
URL: https://github.com/apache/incubator-pinot/pull/5115#issuecomment-595424322
 
 
   ColumnMetadata has getTextIndexType which is either NONE or LUCENE at this point to indicate whether the on-disk segment doesn't have a text index (NONE) or what kind (LUCENE). Our goal was to use this in future when we move to native text indexes and load segments appropriately or convert from lucene text to native text.
   
   In the current implementation, getTextIndexType() is being used only in the tests. However, my plan was to use it in PhysicalColumnIndexContainer to load.
   
   Looks like this will continue to be the same since we can use ColumnMetadata for everything before query execution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org