You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/03/27 01:10:13 UTC
[GitHub] [spark] itholic opened a new pull request, #40554: [SPARK-42914][PYTHON][3.4] Reuse `transformUnregisteredFunction` for `DistributedSequenceID`.
itholic opened a new pull request, #40554:
URL: https://github.com/apache/spark/pull/40554
### What changes were proposed in this pull request?
Backport for https://github.com/apache/spark/pull/40540
This PR proposes refactoring `DistributedSequenceID` by leveraging `transformUnregisteredFunction` and remote it from proto message.
### Why are the changes needed?
To follow the existing structure and make proto messages simpler.
### Does this PR introduce _any_ user-facing change?
No, it's used for internal purpose.
### How was this patch tested?
Updated UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40554: [SPARK-42914][PYTHON][3.4] Reuse `transformUnregisteredFunction` for `DistributedSequenceID`.
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40554:
URL: https://github.com/apache/spark/pull/40554#issuecomment-1484345121
Oh im sorry. Actually we don't need this for 3.4 since pandas API in spark will be in 3.5 only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #40554: [SPARK-42914][PYTHON][3.4] Reuse `transformUnregisteredFunction` for `DistributedSequenceID`.
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #40554:
URL: https://github.com/apache/spark/pull/40554#issuecomment-1484321981
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #40554: [SPARK-42914][PYTHON][3.4] Reuse `transformUnregisteredFunction` for `DistributedSequenceID`.
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #40554:
URL: https://github.com/apache/spark/pull/40554#issuecomment-1484345630
np!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40554: [SPARK-42914][PYTHON][3.4] Reuse `transformUnregisteredFunction` for `DistributedSequenceID`.
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40554: [SPARK-42914][PYTHON][3.4] Reuse `transformUnregisteredFunction` for `DistributedSequenceID`.
URL: https://github.com/apache/spark/pull/40554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org