You are viewing a plain text version of this content. The canonical link for it is here.
Posted to npanday-commits@incubator.apache.org by "Paul G (JIRA)" <ji...@apache.org> on 2010/12/01 15:10:11 UTC
[jira] Created: (NPANDAY-356) Addin 'resync references' feature
fails to download latest SNAPSHOT from remote repo if older snapshot file
already exists locally.
Addin 'resync references' feature fails to download latest SNAPSHOT from remote repo if older snapshot file already exists locally.
-----------------------------------------------------------------------------------------------------------------------------------
Key: NPANDAY-356
URL: https://issues.apache.org/jira/browse/NPANDAY-356
Project: NPanday
Issue Type: Bug
Components: Visual Studio Add-in
Affects Versions: 1.2.1
Environment: Windows
Reporter: Paul G
The VisualStudio.Addin's ReferenceManager.cs simply checks for the presence of a snapshot artifact file in the local repo, and if it's present it copies it to the project's reference folder. No attempt to check the remote snapshot state
To fix this I did the following:
In ReferenceManager.cs line 94, replace:
if (!artifact.FileInfo.Exists)
with
if (!artifact.FileInfo.Exists || artifact.Version.EndsWith("SNAPSHOT"))
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NPANDAY-356) Addin 'resync references' feature
fails to download latest SNAPSHOT from remote repo if older snapshot file
already exists locally.
Posted by "Paul G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977245#action_12977245 ]
Paul G commented on NPANDAY-356:
--------------------------------
I've double-checked, and am pretty confident that the change will not cause redownloading of unchanged snapshots, since it first checks the snapshot timestamp.
> Addin 'resync references' feature fails to download latest SNAPSHOT from remote repo if older snapshot file already exists locally.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: NPANDAY-356
> URL: https://issues.apache.org/jira/browse/NPANDAY-356
> Project: NPanday
> Issue Type: Bug
> Components: Visual Studio Add-in
> Affects Versions: 1.2.1
> Environment: Windows
> Reporter: Paul G
> Attachments: NPANDAY-356.patch
>
>
> The VisualStudio.Addin's ReferenceManager.cs simply checks for the presence of a snapshot artifact file in the local repo, and if it's present it copies it to the project's reference folder. No attempt to check the remote snapshot state
> To fix this I did the following:
> In ReferenceManager.cs line 94, replace:
> if (!artifact.FileInfo.Exists)
> with
> if (!artifact.FileInfo.Exists || artifact.Version.EndsWith("SNAPSHOT"))
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NPANDAY-356) Addin 'resync references' feature
fails to download latest SNAPSHOT from remote repo if older snapshot file
already exists locally.
Posted by "Paul G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966016#action_12966016 ]
Paul G commented on NPANDAY-356:
--------------------------------
I'm pretty sure that the fix sends the code off to check the remote snapshot's timestamp and the download only occurs if the it's greater than the local one. I'll double-check next time I'm there.
> Addin 'resync references' feature fails to download latest SNAPSHOT from remote repo if older snapshot file already exists locally.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: NPANDAY-356
> URL: https://issues.apache.org/jira/browse/NPANDAY-356
> Project: NPanday
> Issue Type: Bug
> Components: Visual Studio Add-in
> Affects Versions: 1.2.1
> Environment: Windows
> Reporter: Paul G
>
> The VisualStudio.Addin's ReferenceManager.cs simply checks for the presence of a snapshot artifact file in the local repo, and if it's present it copies it to the project's reference folder. No attempt to check the remote snapshot state
> To fix this I did the following:
> In ReferenceManager.cs line 94, replace:
> if (!artifact.FileInfo.Exists)
> with
> if (!artifact.FileInfo.Exists || artifact.Version.EndsWith("SNAPSHOT"))
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NPANDAY-356) Addin 'resync references' feature
fails to download latest SNAPSHOT from remote repo if older snapshot file
already exists locally.
Posted by "Adelita L. Padilla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adelita L. Padilla updated NPANDAY-356:
---------------------------------------
Fix Version/s: 1.3-incubating
> Addin 'resync references' feature fails to download latest SNAPSHOT from remote repo if older snapshot file already exists locally.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: NPANDAY-356
> URL: https://issues.apache.org/jira/browse/NPANDAY-356
> Project: NPanday
> Issue Type: Bug
> Components: Visual Studio Add-in
> Affects Versions: 1.2.1
> Environment: Windows
> Reporter: Paul G
> Fix For: 1.3-incubating
>
> Attachments: NPANDAY-356.patch
>
>
> The VisualStudio.Addin's ReferenceManager.cs simply checks for the presence of a snapshot artifact file in the local repo, and if it's present it copies it to the project's reference folder. No attempt to check the remote snapshot state
> To fix this I did the following:
> In ReferenceManager.cs line 94, replace:
> if (!artifact.FileInfo.Exists)
> with
> if (!artifact.FileInfo.Exists || artifact.Version.EndsWith("SNAPSHOT"))
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (NPANDAY-356) Addin 'resync
references' feature fails to download latest SNAPSHOT from remote repo if
older snapshot file already exists locally.
Posted by "Paul G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966016#action_12966016 ]
Paul G edited comment on NPANDAY-356 at 12/2/10 6:07 AM:
---------------------------------------------------------
I'm pretty sure that the fix causes the addin to check the remote snapshot's timestamp and the download only occurs if the it's greater than the local one. I'll double-check next time I'm there.
was (Author: paulgr):
I'm pretty sure that the fix sends the code off to check the remote snapshot's timestamp and the download only occurs if the it's greater than the local one. I'll double-check next time I'm there.
> Addin 'resync references' feature fails to download latest SNAPSHOT from remote repo if older snapshot file already exists locally.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: NPANDAY-356
> URL: https://issues.apache.org/jira/browse/NPANDAY-356
> Project: NPanday
> Issue Type: Bug
> Components: Visual Studio Add-in
> Affects Versions: 1.2.1
> Environment: Windows
> Reporter: Paul G
> Attachments: NPANDAY-356.patch
>
>
> The VisualStudio.Addin's ReferenceManager.cs simply checks for the presence of a snapshot artifact file in the local repo, and if it's present it copies it to the project's reference folder. No attempt to check the remote snapshot state
> To fix this I did the following:
> In ReferenceManager.cs line 94, replace:
> if (!artifact.FileInfo.Exists)
> with
> if (!artifact.FileInfo.Exists || artifact.Version.EndsWith("SNAPSHOT"))
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (NPANDAY-356) Addin 'resync references' feature
fails to download latest SNAPSHOT from remote repo if older snapshot file
already exists locally.
Posted by "Joe Ocaba (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Ocaba resolved NPANDAY-356.
-------------------------------
Resolution: Fixed
Assignee: Joe Ocaba
Applied patch in trunk.
> Addin 'resync references' feature fails to download latest SNAPSHOT from remote repo if older snapshot file already exists locally.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: NPANDAY-356
> URL: https://issues.apache.org/jira/browse/NPANDAY-356
> Project: NPanday
> Issue Type: Bug
> Components: Visual Studio Add-in
> Affects Versions: 1.2.1
> Environment: Windows
> Reporter: Paul G
> Assignee: Joe Ocaba
> Fix For: 1.3-incubating
>
> Attachments: NPANDAY-356.patch
>
>
> The VisualStudio.Addin's ReferenceManager.cs simply checks for the presence of a snapshot artifact file in the local repo, and if it's present it copies it to the project's reference folder. No attempt to check the remote snapshot state
> To fix this I did the following:
> In ReferenceManager.cs line 94, replace:
> if (!artifact.FileInfo.Exists)
> with
> if (!artifact.FileInfo.Exists || artifact.Version.EndsWith("SNAPSHOT"))
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NPANDAY-356) Addin 'resync references' feature
fails to download latest SNAPSHOT from remote repo if older snapshot file
already exists locally.
Posted by "Brett Porter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965906#action_12965906 ]
Brett Porter commented on NPANDAY-356:
--------------------------------------
you're right, this was a known limitation. I'd need to look closer if this fix is correct, since it might result in redownloading snapshots if they haven't changed (though that is probably a better alternative than the current problem).
Another workaround is to run a build via the "run" menu once.
> Addin 'resync references' feature fails to download latest SNAPSHOT from remote repo if older snapshot file already exists locally.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: NPANDAY-356
> URL: https://issues.apache.org/jira/browse/NPANDAY-356
> Project: NPanday
> Issue Type: Bug
> Components: Visual Studio Add-in
> Affects Versions: 1.2.1
> Environment: Windows
> Reporter: Paul G
>
> The VisualStudio.Addin's ReferenceManager.cs simply checks for the presence of a snapshot artifact file in the local repo, and if it's present it copies it to the project's reference folder. No attempt to check the remote snapshot state
> To fix this I did the following:
> In ReferenceManager.cs line 94, replace:
> if (!artifact.FileInfo.Exists)
> with
> if (!artifact.FileInfo.Exists || artifact.Version.EndsWith("SNAPSHOT"))
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NPANDAY-356) Addin 'resync references' feature
fails to download latest SNAPSHOT from remote repo if older snapshot file
already exists locally.
Posted by "Paul G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul G updated NPANDAY-356:
---------------------------
Attachment: NPANDAY-356.patch
> Addin 'resync references' feature fails to download latest SNAPSHOT from remote repo if older snapshot file already exists locally.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: NPANDAY-356
> URL: https://issues.apache.org/jira/browse/NPANDAY-356
> Project: NPanday
> Issue Type: Bug
> Components: Visual Studio Add-in
> Affects Versions: 1.2.1
> Environment: Windows
> Reporter: Paul G
> Attachments: NPANDAY-356.patch
>
>
> The VisualStudio.Addin's ReferenceManager.cs simply checks for the presence of a snapshot artifact file in the local repo, and if it's present it copies it to the project's reference folder. No attempt to check the remote snapshot state
> To fix this I did the following:
> In ReferenceManager.cs line 94, replace:
> if (!artifact.FileInfo.Exists)
> with
> if (!artifact.FileInfo.Exists || artifact.Version.EndsWith("SNAPSHOT"))
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.