You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/10/10 13:29:56 UTC
Review Request 26548: UI: REST API Changes in Storm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26548/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.
Bugs: AMBARI-7721
https://issues.apache.org/jira/browse/AMBARI-7721
Repository: ambari
Description
-------
We need to make changes for Storm rest api metrics from UI side.
In stack 2.2 STORM_REST_API will not be included. All api calls will be added to STORM_UI_SERVER.
Example:
{code}
http://c6402.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6402.ambari.apache.org/host_components/STORM_UI_SERVER
{code}
{code}
"metrics" : {
"api" : {
"v1" : {
"cluster" : {
"summary" : {
"executorsTotal" : 28.0,
"nimbusUptime" : "15m 1s",
"slotsFree" : 0.0,
"slotsTotal" : 2.0,
"slotsUsed" : 2.0,
"supervisors" : 1.0,
"tasksTotal" : 28.0
}
},
"topology" : {
"summary" : [
{
"executorsTotal" : 28.0,
"uptime" : "5m 59s",
"schedulerInfo" : null,
"name" : "WordCountida8c06640_date2901141",
"workersTotal" : 2.0,
"status" : "ACTIVE",
"owner" : "",
"tasksTotal" : 28.0,
"id" : "WordCountida8c06640_date2901141-2-1412195707"
}
]
}
}
{code}
Note: Now we need to calculate a number of topologies from this data.
Diffs
-----
ambari-web/app/controllers/global/update_controller.js a71f689
ambari-web/app/mappers/service_metrics_mapper.js 1ee93bc
ambari-web/app/models/service/storm.js f061d31
ambari-web/app/utils/date.js 671ec02
ambari-web/app/utils/helper.js b5ce069
ambari-web/app/views/main/service/services/storm.js 3546cd0
ambari-web/test/controllers/global/update_controller_test.js a880b1b
ambari-web/test/mappers/service_mapper_test.js e291ae7
ambari-web/test/utils/helper_test.js f75c1e4
Diff: https://reviews.apache.org/r/26548/diff/
Testing
-------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12674151/AMBARI-7721_branch-1.7.0.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/144//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/144//console
Thanks,
Oleg Nechiporenko
Re: Review Request 26548: UI: REST API Changes in Storm
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26548/#review56118
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Окт. 10, 2014, 11:29 д.п., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26548/
> -----------------------------------------------------------
>
> (Updated Окт. 10, 2014, 11:29 д.п.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.
>
>
> Bugs: AMBARI-7721
> https://issues.apache.org/jira/browse/AMBARI-7721
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need to make changes for Storm rest api metrics from UI side.
> In stack 2.2 STORM_REST_API will not be included. All api calls will be added to STORM_UI_SERVER.
>
> Example:
> {code}
> http://c6402.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6402.ambari.apache.org/host_components/STORM_UI_SERVER
> {code}
>
> {code}
> "metrics" : {
> "api" : {
> "v1" : {
> "cluster" : {
> "summary" : {
> "executorsTotal" : 28.0,
> "nimbusUptime" : "15m 1s",
> "slotsFree" : 0.0,
> "slotsTotal" : 2.0,
> "slotsUsed" : 2.0,
> "supervisors" : 1.0,
> "tasksTotal" : 28.0
> }
> },
> "topology" : {
> "summary" : [
> {
> "executorsTotal" : 28.0,
> "uptime" : "5m 59s",
> "schedulerInfo" : null,
> "name" : "WordCountida8c06640_date2901141",
> "workersTotal" : 2.0,
> "status" : "ACTIVE",
> "owner" : "",
> "tasksTotal" : 28.0,
> "id" : "WordCountida8c06640_date2901141-2-1412195707"
> }
> ]
> }
> }
> {code}
>
> Note: Now we need to calculate a number of topologies from this data.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/global/update_controller.js a71f689
> ambari-web/app/mappers/service_metrics_mapper.js 1ee93bc
> ambari-web/app/models/service/storm.js f061d31
> ambari-web/app/utils/date.js 671ec02
> ambari-web/app/utils/helper.js b5ce069
> ambari-web/app/views/main/service/services/storm.js 3546cd0
> ambari-web/test/controllers/global/update_controller_test.js a880b1b
> ambari-web/test/mappers/service_mapper_test.js e291ae7
> ambari-web/test/utils/helper_test.js f75c1e4
>
> Diff: https://reviews.apache.org/r/26548/diff/
>
>
> Testing
> -------
>
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12674151/AMBARI-7721_branch-1.7.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 3 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> +1 release audit. The applied patch does not increase the total number of release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/144//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/144//console
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 26548: UI: REST API Changes in Storm
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26548/#review56119
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Жов. 10, 2014, 11:29 до полудня, Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26548/
> -----------------------------------------------------------
>
> (Updated Жов. 10, 2014, 11:29 до полудня)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.
>
>
> Bugs: AMBARI-7721
> https://issues.apache.org/jira/browse/AMBARI-7721
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need to make changes for Storm rest api metrics from UI side.
> In stack 2.2 STORM_REST_API will not be included. All api calls will be added to STORM_UI_SERVER.
>
> Example:
> {code}
> http://c6402.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6402.ambari.apache.org/host_components/STORM_UI_SERVER
> {code}
>
> {code}
> "metrics" : {
> "api" : {
> "v1" : {
> "cluster" : {
> "summary" : {
> "executorsTotal" : 28.0,
> "nimbusUptime" : "15m 1s",
> "slotsFree" : 0.0,
> "slotsTotal" : 2.0,
> "slotsUsed" : 2.0,
> "supervisors" : 1.0,
> "tasksTotal" : 28.0
> }
> },
> "topology" : {
> "summary" : [
> {
> "executorsTotal" : 28.0,
> "uptime" : "5m 59s",
> "schedulerInfo" : null,
> "name" : "WordCountida8c06640_date2901141",
> "workersTotal" : 2.0,
> "status" : "ACTIVE",
> "owner" : "",
> "tasksTotal" : 28.0,
> "id" : "WordCountida8c06640_date2901141-2-1412195707"
> }
> ]
> }
> }
> {code}
>
> Note: Now we need to calculate a number of topologies from this data.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/global/update_controller.js a71f689
> ambari-web/app/mappers/service_metrics_mapper.js 1ee93bc
> ambari-web/app/models/service/storm.js f061d31
> ambari-web/app/utils/date.js 671ec02
> ambari-web/app/utils/helper.js b5ce069
> ambari-web/app/views/main/service/services/storm.js 3546cd0
> ambari-web/test/controllers/global/update_controller_test.js a880b1b
> ambari-web/test/mappers/service_mapper_test.js e291ae7
> ambari-web/test/utils/helper_test.js f75c1e4
>
> Diff: https://reviews.apache.org/r/26548/diff/
>
>
> Testing
> -------
>
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12674151/AMBARI-7721_branch-1.7.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 3 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> +1 release audit. The applied patch does not increase the total number of release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/144//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/144//console
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>