You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/10/01 00:19:48 UTC
[GitHub] [hbase] ndimiduk commented on a change in pull request #2163: HBASE-24789 When table level quota is set and violated, pre existing …
ndimiduk commented on a change in pull request #2163:
URL: https://github.com/apache/hbase/pull/2163#discussion_r497871489
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotaManager.java
##########
@@ -284,6 +285,9 @@ public void delete() throws IOException {
SpaceQuotaSnapshot currSnapshotOfTable =
QuotaTableUtil.getCurrentSnapshotFromQuotaTable(masterServices.getConnection(), table);
QuotaUtil.deleteTableQuota(masterServices.getConnection(), table);
+ // Removes the tableName from the current state in QuotaObserverChore
+ QuotaObserverChore quotaChore = ((HMaster)masterServices).getQuotaObserverChore();
Review comment:
I'm wondering if we should update the `MasterServices` interface to include access to the chores. This kind of inline casting defeats the purpose of having the `MasterServices` interface in the first place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org